Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard mapping #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Keyboard mapping #13

wants to merge 4 commits into from

Conversation

csaez
Copy link

@csaez csaez commented Jan 7, 2014

Hi Steven,

Do you remember issue #10?
#10

Today I have finally given it a try, the keyboard mapping dictionaries are now submodules of the key_mapping package. There are also some functions to list/get/set the language on key_mapping's init file, a new softimage command exposing those functions and a json file where the preferences are stored.

You have to restart Softimage in order to use different keyboard mappings (modules get cached by python), the french mapping is a copy/paste of #10 (comment).

Do you think it worth the merge?
Cheers!

@csaez
Copy link
Author

csaez commented Jan 7, 2014

I can package the modified addon (based on beta5) in case you want to test the changes.

@caron
Copy link
Owner

caron commented Jan 7, 2014

thanks a lot for this cesar! i think it is worth a merge, i skimmed over it and it looks good. (thanks for fixing some of lines greater than 79 columns)

just so i am clear, you forked from the beta5 tag? cause it looks like you have the experimental pyside support. i should have done my pyside work in a different branch but i didn't expect to get blocked by the ui loader issues.

@csaez
Copy link
Author

csaez commented Jan 7, 2014

Ooops! seems like I forked from the latest one :(

@caron
Copy link
Owner

caron commented Jan 7, 2014

well, its ok... i am thinking of getting the pyside support out there and using another method for the ui loader class. this will also test pyqt4 coexisting. ie. if you don't have pyside, pyqt4 should behave as normal.

i can also add your key mapping work to it. if for some reason people don't want to upgrade, we can make a beta5.1 version with only your key mapping additions.

@csaez
Copy link
Author

csaez commented Jan 7, 2014

Sounds good, let me know if you need any help :)

@caron caron force-pushed the master branch 2 times, most recently from 98a2e97 to 35b4571 Compare August 10, 2015 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants