Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADANATOR to Builder Tools #968

Closed
wants to merge 11 commits into from

Conversation

Godspeed-exe
Copy link
Contributor

👋👋 Hello there! Welcome. Please follow the instruction below.

Click the Preview tab and select a PR template:

Add ADANATOR

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how we could possibly approve this to be placed among our existing hosted services, given that:

  • there is no free tier (or even a low-cost tier)
  • there is no online documentation

@Godspeed-exe please post here if I am wrong about either of these observations.

src/data/builder-tools.js Outdated Show resolved Hide resolved
@rphair rphair changed the title Patch 2 Add ADANATOR to Builder Tools Feb 21, 2023
@rphair rphair added the builder tool Indicates a PR/issue on a builder tool label Feb 21, 2023
@Godspeed-exe
Copy link
Contributor Author

I wasn't aware of the requirements, I'll get on that! 😄

@rphair
Copy link
Collaborator

rphair commented Feb 22, 2023

@Godspeed-exe neither of these are "requirements" but rather the ways in which the providers of these hosted services generally invite adoption... which is consistent with the Developer Portal's mission to promote Cardano adoption overall.

@Godspeed-exe
Copy link
Contributor Author

@rphair I've added a free tier and linked to the GraphQL documentation.
I'm also adding an embedded GraphiQL editor but this being a PITA.

Let me know if you have any further suggestions or questions!

rphair
rphair previously approved these changes Mar 20, 2023
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Godspeed-exe thanks for adding the free tier: it's a good step forward. I had been hoping to see some more documentation: the button link just goes to a viewer for the DB schema rather than any description of your service itself works.

Other reviewers: I found it was possible to get through it in a couple minutes just signing up for the free tier & following the bouncing ball. I think it's a help to have this on the Dev Portal for the one reason that it gives people a cardano-graphql environment in which they can make 1000 requests per day as they are learning.

@Godspeed-exe do I remember correctly that the price was $50 per month when I did my last review (it's $100 now)? If so, maybe this is to make up for the presentation of a free tier? In either case, if I were considering one of your enterprise subscriptions I would be put off by the thin & somewhat buggy web site with no documentation about your back end or support commitments.

@rdlrt
Copy link
Collaborator

rdlrt commented Mar 20, 2023

No-go for me to review, it's a simple graphql instance(s) served online - fail to see any value-add compared to what's already served via dandelion, the efforts taken (be it this PR itself, the website or lack of helpful content to know/interact further) feel really discouraging to me

PS: Not a fan of self-submission to favourite tag either, and in-spite of review comments, the submitter did not care to remove the tag himself.

@rphair
Copy link
Collaborator

rphair commented Mar 20, 2023

@rdlrt this also reflects my own feelings except that I'm also considering the importance of having something even lighter-weight than dandelion for educational purposes. But there is also the issue of professional endorsement of the paid service to consider, which I'd be unwilling to do... but which might be implied by its appearance on the Dev Portal 🤔

@rphair rphair dismissed their stale review March 20, 2023 09:18

found Dandelion equivalent (hosted, not Kerberos install)

@rphair
Copy link
Collaborator

rphair commented Mar 20, 2023

p.s. @rdlrt now I see: I'd just been looking at Dandelion's Kubernetes installation (I typo'd Kerberos above, which I can't edit) and not the free/hosted service referred to here via the Get Started page for Dandelion. So my assertion was incorrect that this service is beneficial based on the free tier.

@Godspeed-exe
Copy link
Contributor Author

@rphair thanks for the input!

As mentioned I've added a public Graphiql Playground (like the Hasura interface) I had to secure this before adding it into the frontend. Glad to hear you were able to register easily and get access to it.

  • I've added a contact link for reaching out on the Dashboard for support.
  • The website started off as a TransactionBuilder for someone in the community, I only spent a few hours on this (hence the buggy and thin) - it's work in progress.
  • It's similar to Dandelion indeed, but I've talked to Roberto (he's aware of my project), but exposing a raw GraphQL to the public makes it easy to abuse / overuse. Hence, separating free and paid users. There are enterprises that want to build but don't want to run their own. Look at Blockfrost (amazing job on the API) but GraphQL is also pretty widely used, hence this initiave.

@rdlrt

  • Sorry for initially adding the "favorite" tag, I think this has been removed (by @rphair ) in the meantime?
  • you are correct that it's multiple graphql instances
  • it's not exactly like Dandelion, since it's load balanced across multiple instances and keeping track of API counts while having it's own Playground. Like mentioned above Dandelion is great for learning but it's often offline, which isn't great for enterprises.

I do admit that it needs more "make up", but it's still an early version. I'm also planning on adding other functionalities in the future, sadly time is as scarce as Bitcoin.

Let me know what else you are looking for, happy to hear constructive feedback about how to improve!

Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit slow, but worked for me

@katomm
Copy link
Member

katomm commented Dec 4, 2023

The pull request has not received the required approvals and is closed. However, it can be opened again. Details on: https://developers.cardano.org/docs/portal-contribute/#how-are-pull-requests-reviewed

In any case, the discussion can be continued here.

@katomm katomm closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder tool Indicates a PR/issue on a builder tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants