-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cardano Relay Configuration: fix & clarify instructions #1162
Conversation
Documentation Update cardano-foundation#1140
Documentation Update cardano-foundation#1140
Documentation Update cardano-foundation#1140
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this page is maintainable for reasons @rdlrt already gave in #1140 (comment) ... and therefore I believe most of the content on this page should be replaced with links to the relevant sections on the canonical page Installing cardano-node and cardano-cli from source.
As long as the redundancy in the page remains, though, we would still have to do some cleanup. Some feedback about the proposed changes:
if a cleanup is planned, should i close this PR. Alternatively, i could make the suggested changes as an interim solution? |
@sanskys I would want to hear what other reviewers think about this, but I still firmly believe the only suitable change to make to this page is to eliminate the redundant material, replacing it with link(s) to the more canonical Dev Portal source. Perhaps the page & workflow could be simplified with wording like: "Now that you've created a node according to these (link) standard instructions, here's how to configure it as a relay for your stake pool." In any case I believe it would be a huge contribution if you could revise your fixes to strip down most of the content & only include those instructions that are unique to SPOs & their relays, without the general node maintenance & operation. What do you think of that plan? 🤓 |
@rphair thats fine for me. But since the cleanup would take some time, I would recommend to merge these changes and open a new Issue. I would also like to hear more voices before starting. It should not be that after the cleanup everyone finds it a mishmash :) |
sure thing @sanskys - I'll approve this for merge if it gets approval from 2 other reviewers. 🙂 |
I've backed out all the superflous & contraindicated changes from the standard |
yarn build
after adding my changes without getting any errors.Updating documentation or Bugfix
Documentation Update to Fix #1140