-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CIP-25 and CIP-68 References #1018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and LGTM
Thank you. To keep the current tutorial style, we should show how to use CIP-68 without using an external service. I think that would be a much-appreciated contribution. Could you provide that? |
Yes I will add this using CardanoSharp =) |
@katomm @nothingalike @rdlrt added an open source repo example for CIP-68 NFTs using CardanoSharp as well as policyId warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look like open source method as per @katomm #1018 (comment) is now addressed, but for the warning as per @rdlrt #1018 (comment) although there is some ordinary text I think @NicholasMaselli we need to call out the risks a little more, to be sure they notice someone else is owning the minting policy as in other highlighted risks you've seen elsewhere on the Dev Portal:
@NicholasMaselli do you need anything else to finish this off? thanks |
(cc @katomm) @NicholasMaselli your base in The only thing I can see missing is a warning about using an external service to create a dynamic NFT as suggested in #1018 (comment). From all the |
Bumping this as CIP-68 is gaining substantial popularity |
@NicholasMaselli I believe #1018 (comment) still needs to be resolved, unless you can quote something on your revised page to show this has been addressed already. |
Best to follow Roberts suggestion with the admonition, and then we can bring this in. |
Done! |
Updated =) I also change the note to an important for the blue highlight as the standards are important information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks; just checked in a local build ✔️ and it really does look & work better with the admonitions in the new material.
The NFT minting page is extremely outdated, saying there are no standards for Cardano NFTs. This PR updates the developer portal to indicate CIP-25 and CIP-68 Cardano NFTs and resources
This is a documentation update to the NFT minting page