Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CIP-25 and CIP-68 References #1018

Merged
merged 18 commits into from
Aug 14, 2023

Conversation

cardano-dev4
Copy link

The NFT minting page is extremely outdated, saying there are no standards for Cardano NFTs. This PR updates the developer portal to indicate CIP-25 and CIP-68 Cardano NFTs and resources

This is a documentation update to the NFT minting page

  • [Update documentation or Fix a Bug]

Copy link
Contributor

@nothingalike nothingalike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and LGTM

@katomm
Copy link
Member

katomm commented Apr 11, 2023

Thank you. To keep the current tutorial style, we should show how to use CIP-68 without using an external service. I think that would be a much-appreciated contribution. Could you provide that?

@cardano-dev4
Copy link
Author

Thank you. To keep the current tutorial style, we should show how to use CIP-68 without using an external service. I think that would be a much-appreciated contribution. Could you provide that?

Yes I will add this using CardanoSharp =)

@cardano-dev4
Copy link
Author

Thank you. To keep the current tutorial style, we should show how to use CIP-68 without using an external service. I think that would be a much-appreciated contribution. Could you provide that?

@katomm @nothingalike @rdlrt added an open source repo example for CIP-68 NFTs using CardanoSharp as well as policyId warning

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like open source method as per @katomm #1018 (comment) is now addressed, but for the warning as per @rdlrt #1018 (comment) although there is some ordinary text I think @NicholasMaselli we need to call out the risks a little more, to be sure they notice someone else is owning the minting policy as in other highlighted risks you've seen elsewhere on the Dev Portal:

@rphair rphair added the documentation Improvements or additions to documentation label Apr 27, 2023
@katomm
Copy link
Member

katomm commented Jul 5, 2023

@NicholasMaselli do you need anything else to finish this off? thanks

@rphair
Copy link
Collaborator

rphair commented Jul 6, 2023

(cc @katomm) @NicholasMaselli your base in staging was old & this PR branch wouldn't build locally so I merged in staging and now it is building properly. The documentation looks good to me, thanks. 😎

The only thing I can see missing is a warning about using an external service to create a dynamic NFT as suggested in #1018 (comment). From all the :::note's in this document I can see you know how to use "admonitions" as suggested in #1018 (review) and I think this should be a :::caution.

@cardano-dev4
Copy link
Author

Bumping this as CIP-68 is gaining substantial popularity

@rphair
Copy link
Collaborator

rphair commented Jul 19, 2023

@NicholasMaselli I believe #1018 (comment) still needs to be resolved, unless you can quote something on your revised page to show this has been addressed already.

@katomm
Copy link
Member

katomm commented Aug 1, 2023

Best to follow Roberts suggestion with the admonition, and then we can bring this in.

@cardano-dev4
Copy link
Author

Thank you. To keep the current tutorial style, we should show how to use CIP-68 without using an external service. I think that would be a much-appreciated contribution. Could you provide that?

Done!

@cardano-dev4
Copy link
Author

@NicholasMaselli I believe #1018 (comment) still needs to be resolved, unless you can quote something on your revised page to show this has been addressed already.

Updated =) I also change the note to an important for the blue highlight as the standards are important information

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks; just checked in a local build ✔️ and it really does look & work better with the admonitions in the new material.

@cardano-dev4
Copy link
Author

@katomm and @rdlrt it looks like the other are happy with the changes. I believe this needs 1 more review for merge. Let me know if you need anything else from me =)

@rphair rphair merged commit fcce876 into cardano-foundation:staging Aug 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants