fix: support hashed content CIP-30 data content which is typically g… #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiwinnetou
requested review from
jimcase,
satran004,
jorgenavben and
nemo83
matiwinnetou
commented
Sep 29, 2024
| @@ -78,7 +79,7 @@ dependencies { | |||
| runtimeOnly("org.postgresql:postgresql") | |||
|
|
|||
| implementation("org.cardanofoundation:merkle-tree-java:0.0.7") | |||
| implementation("org.cardanofoundation:cip30-data-signature-parser:0.0.11") | |||
| implementation("org.cardanofoundation:cip30-data-signature-parser:0.0.12-SNAPSHOT") | |||
There was a problem hiding this comment.
TODO:
change when released 0.0.12 to maven central
matiwinnetou
requested review from
rcmorano
and removed request for
rcmorano,
nemo83,
jimcase,
satran004 and
jorgenavben
matiwinnetou
force-pushed
the
hardware-wallet-fix
branch
from
a71479f
to
0b870a5
Compare
matiwinnetou
commented
Sep 29, 2024
| @@ -28,6 +28,7 @@ configurations { | |||
| } | |||
|
|
|||
| repositories { | |||
| mavenLocal() | |||
There was a problem hiding this comment.
TODO remove when cip30-data-signature-parser:0.0.12-SNAPSHOT is released
There was a problem hiding this comment.
This is actually safe to keep it as well, right?
matiwinnetou
commented
Sep 29, 2024
| @@ -60,7 +60,7 @@ public class Vote extends AbstractTimestampEntity { | |||
| private String signature; | |||
|
|
|||
| @Column(name = "payload", nullable = false, columnDefinition = "text", length = 2048) | |||
| @Nullable | |||
| @Nullable // TODO remove nullable since payload is now always required | |||
There was a problem hiding this comment.
in future releases, don't wanna do db migration now, too risky and not necessary.
matiwinnetou
force-pushed
the
hardware-wallet-fix
branch
from
0b870a5
to
bf8f892
Compare
matiwinnetou
requested review from
rcmorano,
ThomasADA,
fabianbormann and
satran004
matiwinnetou
changed the title
matiwinnetou
force-pushed
the
hardware-wallet-fix
branch
from
bf8f892
to
8a73123
Compare
…enerated by hardware wallets.
matiwinnetou
force-pushed
the
hardware-wallet-fix
branch
from
8a73123
to
372bc34
Compare
gitmachtl
reviewed
Sep 30, 2024
| @@ -122,7 +125,37 @@ protected void doFilterInternal(HttpServletRequest req, | |||
|
|
|||
| val walletId = maybeAddress.orElseThrow(); | |||
|
|
|||
| val cipBody = cipVerificationResult.getMessage(MessageFormat.TEXT); | |||
| var cipBody = cipVerificationResult.getMessage(MessageFormat.TEXT); | |||
There was a problem hiding this comment.
because i saw this: a cose_sign1 signature/structure is still valid even without a payload embedded. not sure how often this is used, but the requesting process already know the payload, so there is no 100% need to have a payload included.
rcmorano
approved these changes
Oct 2, 2024
| @@ -28,6 +28,7 @@ configurations { | |||
| } | |||
|
|
|||
| repositories { | |||
| mavenLocal() | |||
There was a problem hiding this comment.
This is actually safe to keep it as well, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enerated by hardware wallets.
Many thanks to the OG Cardano Community member: Martin Lang (@gitmachtl) in helping to debug and find out the root cause.