Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3443] Add deposits page to deposit UI #4822

Merged
merged 9 commits into from
Oct 28, 2024
Merged

[ADP-3443] Add deposits page to deposit UI #4822

merged 9 commits into from
Oct 28, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Oct 24, 2024 •
edited
Loading

  • Add a deposits page showing 3 levels of details
    • Time, with different windows from 5 mins to 1 year
    • Customers inside the selected time
    • Transaction ids, for the selected customer

ADP-3443

@paolino paolino self-assigned this Oct 24, 2024
@paolino paolino added Deposit UI UI related changes labels Oct 24, 2024
@paolino paolino force-pushed the paolino/ADP-3443/add-transactions-to-address-page branch from 41e90ca to 43dc20e Compare October 25, 2024 08:56
Base automatically changed from paolino/ADP-3443/add-transactions-to-address-page to master October 25, 2024 10:34
@paolino paolino changed the base branch from master to paolino/ADP-3443/use-new-txhistory-in-address-ui-page October 26, 2024 09:08
@paolino paolino force-pushed the paolino/ADP-3443/add-deposits-page-to-ui branch 2 times, most recently from 16e1a5b to 5f8365a Compare October 28, 2024 09:39
@paolino paolino force-pushed the paolino/ADP-3443/use-new-txhistory-in-address-ui-page branch 2 times, most recently from a981090 to f445660 Compare October 28, 2024 16:49
@paolino paolino force-pushed the paolino/ADP-3443/add-deposits-page-to-ui branch from 5f8365a to 395ad31 Compare October 28, 2024 16:51
@paolino paolino marked this pull request as ready for review October 28, 2024 16:53
HeinrichApfelmus
HeinrichApfelmus approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😊 🙏

lib/ui/src/Cardano/Wallet/UI/Deposit/API.hs
@@ -1,15 +1,6 @@
{-# LANGUAGE BlockArguments #-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from paolino/ADP-3443/use-new-txhistory-in-address-ui-page to master October 28, 2024 19:20
@paolino paolino added this pull request to the merge queue Oct 28, 2024
Merged via the queue into master with commit 28efeec Oct 28, 2024
25 checks passed
@paolino paolino deleted the paolino/ADP-3443/add-deposits-page-to-ui branch October 28, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
Deposit UI UI related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus