[ADP-3344] Add currentPParams to NetworkLayer.
#4819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/network-pparams
branch
8 times, most recently
from
1a4d46b
to
de99cb8
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/network-pparams
branch
2 times, most recently
from
ef53212
to
0522825
Compare
Anviking
reviewed
Oct 28, 2024
| @@ -430,7 +429,7 @@ withNetworkLayer tr pipeliningStrategy np conn ver tol action = do | |||
|
|
|||
| -- | Network parameters and protocol parameters for the node's current tip. | |||
| data NetworkParams = NetworkParams | |||
| { protocolParams :: MaybeInRecentEra Write.PParams | |||
| { protocolParams :: Read.EraValue Read.PParams | |||
| , protocolParamsLegacy :: ProtocolParameters | |||
There was a problem hiding this comment.
So now this protocolParamsLegacy could be dropped — if we wanted to
There was a problem hiding this comment.
Yes. The question is whether this investment into the legacy wallet is worth the effort. At the moment, I'd like to freeze it in place, at least.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/network-pparams
branch
from
0522825
to
e759988
Compare
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/network-pparams
branch
from
e759988
to
3b58287
Compare
HeinrichApfelmus
deleted the
HeinrichApfelmus/ADP-3344/network-pparams
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the
NetworkLayerto retrieve era-indexed protocol parameters.In particular, this pull request removes the field
currentProtocolParametersInRecentErasfromNetworkLayerand adds a fieldcurrentPParamsinstead.This pull request also refactors the local state query for
currentProtocolParametersto use a conversion on top ofPParams erainstead of trying to mingle conversion and query.Issue Number
ADP-3344