Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3443] Add tx history to wallet state #4817

Merged
merged 6 commits into from
Oct 23, 2024
Merged

[ADP-3443] Add tx history to wallet state #4817

merged 6 commits into from
Oct 23, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Oct 22, 2024 •
edited
Loading

This PR warm up the deposit-wallet as a preparation to the deposits UI page one

  • Expose the TxHistory in the wallet state
  • Introduce a new type for it, based on nested maps
  • Expand the network layer with time interpreter functionalities

ADP-3443

@paolino paolino self-assigned this Oct 22, 2024
@paolino paolino changed the title Add tx history to wallet state [ADP-3443] Add tx history to wallet state Oct 22, 2024
@paolino paolino force-pushed the paolino/ADP-3443/deposit-wallet-tx-history branch from 2a64ccd to 02419bc Compare October 22, 2024 14:34
HeinrichApfelmus
HeinrichApfelmus approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! 😊 One typo, a wish for the future regarding mwc-random, but nothing that stands in the way of merging this pull request.

lib/customer-deposit-wallet/customer-deposit-wallet.cabal Show resolved Hide resolved
lib/customer-deposit-wallet/src/Cardano/Wallet/Deposit/IO/Network/Mock.hs Show resolved Hide resolved
lib/customer-deposit-wallet/src/Cardano/Wallet/Deposit/Map.hs Outdated Show resolved Hide resolved
lib/customer-deposit-wallet/src/Cardano/Wallet/Deposit/Map.hs Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3443/deposit-wallet-tx-history branch from 02419bc to 1ec7272 Compare October 23, 2024 14:27
@paolino paolino added this pull request to the merge queue Oct 23, 2024
Merged via the queue into master with commit 7fc0d03 Oct 23, 2024
25 checks passed
@paolino paolino deleted the paolino/ADP-3443/deposit-wallet-tx-history branch October 23, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
Deposit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus