[ADP-3344] Add TimeInterpreter to Cardano.Wallet.Deposit.Write [old]

[HeinrichApfelmus]

This pull request imports the TimeInterpreter type in Cardano.Wallet.Deposit.Time and adds it to the NetworkEnv.

Comments

• This pull request is part of the preparations for using balanceTx in createPayment
• Cardano.Wallet.Deposit.Time is a temporary location for the re-export, until we separate out the TimeInterpreter-related stuff into a separate library.

Issue Number

ADP-3344

[paolino]

Can you avoid this pls. Do we need the Interpreter or just some functions in m ?

[HeinrichApfelmus]

Not happy about it either, but I want the TimeInterpreter — it's reasonably well-designed. 🤔 One of the next steps would be to split off the TimeInterpreter into a separate package and get rid of the dependency on -primitive again.

(And also remove the m parameter of the TimeInterpreter, it's more hassle than benefit.)

[Anviking]

From the perspective of createPayment or a deposit wallet specific balanceTx wrapper I suspect you might ideally want to hide both PParams and TimeTranslation inside some single LocalNodeTipStateForTxWrite. Both for the sake of hiding the details, but also for the sake of querying it atomically from the node. But the read side will need the TimeInterpreter, or similar, too.

[Anviking]

also for the sake of querying it atomically from the node

For the deposit wallet this would probably not matter (balanceTx only uses the TimeTranslation to evaluate execution units, and we don't have any UTxO or deposit lookups). In general, perhaps we still deem it not to matter, but it does lead to code like

cardano-wallet/lib/wallet/src/Cardano/Wallet.hs

Lines 2226 to 2242 in aa7fe8c

	-- Assumes the 'utxo' was queried from the node /after/ the 'era'. As
	-- rolling back to a previous era should be impossible, we know 'IsRecentEra
	-- era => IsRecentEra eraOfUTxO'.
	forceUTxOToEra
	:: Write.MaybeInRecentEra Write.UTxO
	-> IO (Write.UTxO era)
	forceUTxOToEra = \case
	InRecentEraConway utxo -> hoist $ Write.forceUTxOToEra utxo
	InRecentEraBabbage utxo -> hoist $ Write.forceUTxOToEra utxo
	InNonRecentEraAlonzo -> impossibleRollback
	InNonRecentEraMary -> impossibleRollback
	InNonRecentEraAllegra -> impossibleRollback
	InNonRecentEraShelley -> impossibleRollback
	InNonRecentEraByron -> impossibleRollback
	where
	impossibleRollback = error "forceUTxOToEra: era should not roll back"
	hoist = either (throwIO . ExceptionInvalidTxOutInEra) pure

[paolino]

I have no problem with the m as long as it's the way to get a pure functions out of it that we can reuse during atomic operations like ingesting a block or translating time in the tx history.
But I would prefer to enumerate the exact functions we need out of it in the interface and leave the implementations of those to later. That would make mocking easier and avoid implementation leaks

[HeinrichApfelmus]

As discussed in a all, I have created a new indirection module Cardano.Wallet.Deposit.Time as a receptacle for slot-time-related stuff which we want to sort out later.

but also for the sake of querying it atomically from the node

That's a fair point. Probably not in this pull request, though.

[paolino]

Thanks!