Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shiori.yml #973

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Update shiori.yml #973

merged 1 commit into from
Aug 1, 2023

Conversation

kgnfth
Copy link
Contributor

@kgnfth kgnfth commented Jul 31, 2023

The latest official docker image did not work with this template so i have updated the template.

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

Copy link
Collaborator

@githubsaturn githubsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MInor comments. Will merge anyways.

public/v4/apps/shiori.yml Show resolved Hide resolved
label: MariaDB User
description: Database User for Shiori
defaultValue: 'shiori'
- id: $$cap_mariadb-pass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest using $$cap_gen_random_hex(16) as a default value for the ease of installation

@githubsaturn githubsaturn merged commit 7d7ba7a into caprover:master Aug 1, 2023
1 check passed
@githubsaturn
Copy link
Collaborator

Thanks!

@kgnfth kgnfth mentioned this pull request Aug 1, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants