Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connected tabular generator with dataset_generator #324
Connected tabular generator with dataset_generator #324
Changes from 30 commits
854bdbb
fcef503
2ba9857
c1d76a0
87a7180
4c84d25
159fe1b
6fdb011
6cf057b
0deeb76
1861b89
a12753a
44fb65c
302a2a3
6fd0aec
31fbd10
6a4f515
3414a34
6f7342d
5ca6916
7e8eb81
a12f66b
f029ea7
1abacd8
7951bc3
10c33f4
c0a43b0
6cc569f
aa0df83
8e7cc35
08b8af2
026e392
eed5ab3
853f8eb
14bee78
6451242
7fc3219
6bb20ab
36aad05
cd333f1
5446141
caabdbf
afb2344
188ba9f
0cac2bb
8c9e267
98f5a4b
58833b6
70d42ae
32f1e1a
8655d17
f289ffd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably only have one seed .. not two of them...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could imagine scenarios where user may want to control different seeds when synthesizing, eg trials in an experiment. Maybe default the seed to self.seed in the func def?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we can clean this up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont' need this