Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_ordered_columns and datetime_generator implementation + tests #313
get_ordered_columns and datetime_generator implementation + tests #313
Changes from all commits
807ea02
fdcf8f5
50979b5
7aba6c9
4b22d2c
09cdc87
83b1601
6a7c967
ab9ec23
668a268
9a85a60
5ec6f25
c6d448b
c98a26d
9835add
41c2e59
a24dbbb
e684cb6
8f7ed4b
d267204
c5a331f
f3a16a3
771e5e6
066b357
a57a65b
48d7f69
46500ba
3feb802
47b0f26
e9612b8
189a969
4cfc611
3748378
4f7b891
d510505
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be sorting by the object or string, @taylorfturner thoughts here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't sorting by string cause it to sort alphabetically instead of by date?