check for is_string_dtype and unsupported mixed type #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdosani
requested review from
ak-gupta,
jdawang and
gladysteh99
as code owners
|
@jdawang @ak-gupta @gladysteh99 friendly ping :) |
gladysteh99
reviewed
Oct 9, 2024
datacompy/core.py
Outdated
Comment on lines
802
to
804
| if pd.api.types.infer_dtype(col_1).startswith("mixed") or pd.api.types.infer_dtype( | ||
| col_1 | ||
| ).startswith("mixed"): |
There was a problem hiding this comment.
is this supposed to be pd.api.types.infer_dtype(col_2).startswith("mixed") instead for the second clause?
ak-gupta
approved these changes
Oct 9, 2024
This was referenced Oct 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327
This is a breaking change in that we would no longer support mixed column types. As one can imagine, that mixed types can get super complex and cumbersome to manage.
The proposal here is to NOT support mixed types moving forward with
v0.14.0