bug fix and clean up of temp_column_name #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdawang
approved these changes
Jun 3, 2024
Merged
rhaffar
pushed a commit
to rhaffar/datacompy
that referenced
this pull request
Sep 11, 2024
rhaffar
pushed a commit
to rhaffar/datacompy
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to have been a hidden bug within
temp_column_name. It scans for an existing column name pattern and will increment by 1 if it already exists. In some cases it would skip and increment by more than 1.This should fix that issue and we can reuse
temp_column_nameacross all the Compare types.Also some general linting and cleanup.