Fix suffix on all mismatches reports #291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enzorooo
requested review from
fdosani,
ak-gupta,
jdawang,
gladysteh99 and
NikhilJArora
as code owners
|
I see that some tests have failed. Though, I'm not exactly sure why that is given the revision is small. If you can provide some guidance for me to fix it, I'd be glad to do it on my end. Thanks! |
|
@enzorooo First off thank you for the PR. Greatly appreciated. I think it is failing cause the test check the formatting of the output which will not match due to the change. Give me a bit here, I'll swing back to this and take a closer look. |
|
Closing in favour of #293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi datacompy team!
I noticed that when using
datacompy.Compare(...).all_mismatches()it defaults to using the"_df1""_df2"strings. Which shouldn't be the case when users have predefined this upon declaring the comparison settings.I fixed it in this contribution. Let me know if it works for you.
Thanks!