Unicode column names fix #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdosani
requested review from
ak-gupta,
jdawang,
gladysteh99 and
NikhilJArora
as code owners
fdosani
force-pushed
the
unicode-column-names-fix
branch
from
4a85479
to
1f37c64
Compare
|
@fdosani Thanks, I confirm it solves the issue I was facing. |
|
@fdosani When do you plan to release v. 0.11.2 with the fix? |
|
Just need someone to review the PR and I can cut a release asap. |
ak-gupta
approved these changes
Mar 19, 2024
Merged
rhaffar
pushed a commit
to rhaffar/datacompy
that referenced
this pull request
Sep 12, 2024
* fixes capitalone#280 * Update test_spark.py * Update test_spark.py * Update test_spark.py * bumping version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #280
@kformanowicz-dotdata would you mind testing this on your end to see if it fixes the program you were having at large?