-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay transforming priority_order into ndarray #969
Delay transforming priority_order into ndarray #969
Commits on Jul 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b63b25d - Browse repository at this point
Copy the full SHA b63b25dView commit details -
Fix/f1 score path fix import (capitalone#952)
* Fixed F1Score Import * Linted example file with Black Linter
Configuration menu - View commit details
-
Copy full SHA for ad6ab58 - Browse repository at this point
Copy the full SHA ad6ab58View commit details -
Scipy bug fix (capitalone#951)
* update * renamed var and removed from for loops * refactored var
Configuration menu - View commit details
-
Copy full SHA for ed95959 - Browse repository at this point
Copy the full SHA ed95959View commit details
Commits on Jul 12, 2023
-
Make BaseDataProcessor.process() compatible with all argument sets (c…
…apitalone#954) A method signature that uses *args: Any, **kwargs: Any is compatible with any set of arguments in mypy, despite being an LSP violation. This lets us assert that subclasses of BaseDataProcessor should have some process() method with an arbitrary signature. We also add to the return type of BaseDataPreprocessor so that it is inclusive of all of its subclasses. Co-authored-by: JGSweets <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 34dad6c - Browse repository at this point
Copy the full SHA 34dad6cView commit details -
Fix name mangling and typevar errors (capitalone#955)
Inside the BaseDataProcessor class definition, references to __subclasses are automatically replaced with _BaseDataProcessor__subclasses. This remains the case even in static methods _register_subclass() and get_class(). Same with BaseModel and its __subclasses field. So we do not have to write out the full name mangled identifiers inside the class definitions. Also, mypy doesn't seem to be able to handle the return type of BaseDataProcessor.get_class() being a typevar, so that was changed to type[BaseDataProcessor]. This does not affect the functionality of get_class() since it always returns a subclass of BaseDataProcessor.
Configuration menu - View commit details
-
Copy full SHA for 5125af4 - Browse repository at this point
Copy the full SHA 5125af4View commit details
Commits on Jul 20, 2023
-
None-check labels dependants (capitalone#964)
The mypy errors addressed here occur because variables label_mapping (in CharPreprocessor), unstructured_labels, and unstructured_label_set (in StructCharPreprocessor.process()) have optional types when they're used. This is fixed by checking that they are not None prior to the operation, which mypy recognizes as removing the None type from them. This should have no effect on functionality because we are already checking that labels is not None, and the variables above all depend on labels such that they are None only if labels is None.
Configuration menu - View commit details
-
Copy full SHA for 92346a3 - Browse repository at this point
Copy the full SHA 92346a3View commit details
Commits on Jul 24, 2023
-
Changed
publish-python-package.yml
to include only release branches. (capitalone#965) * Changed release option to only release branches named \'release/<version-tag>\'. * Reverted types
Configuration menu - View commit details
-
Copy full SHA for acb9c5e - Browse repository at this point
Copy the full SHA acb9c5eView commit details
Commits on Jul 25, 2023
-
Delay transforming priority_order into ndarray
In the changed code, we had a mypy error because numpy ndarrays are not compatible with random.Random.shuffle() (expected argument type is MutableSequence[Any]) We fix this by first instantiating priority_order as a list, then shuffling it, then creating an ndarray from it afterwards.
Configuration menu - View commit details
-
Copy full SHA for 36fc74a - Browse repository at this point
Copy the full SHA 36fc74aView commit details
Commits on Sep 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3ed3afc - Browse repository at this point
Copy the full SHA 3ed3afcView commit details