Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay transforming priority_order into ndarray #969

Closed

Commits on Jul 6, 2023

  1. Configuration menu
    Copy the full SHA
    b63b25d View commit details
    Browse the repository at this point in the history
  2. Fix/f1 score path fix import (capitalone#952)

    * Fixed F1Score Import
    
    * Linted example file with Black Linter
    mxnavid authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ad6ab58 View commit details
    Browse the repository at this point in the history
  3. Scipy bug fix (capitalone#951)

    * update
    
    * renamed var and removed from for loops
    
    * refactored var
    drahc1R authored Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ed95959 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Make BaseDataProcessor.process() compatible with all argument sets (c…

    …apitalone#954)
    
    A method signature that uses *args: Any, **kwargs: Any is compatible
    with any set of arguments in mypy, despite being an LSP violation. This
    lets us assert that subclasses of BaseDataProcessor should have some
    process() method with an arbitrary signature.
    
    We also add to the return type of BaseDataPreprocessor so that it is
    inclusive of all of its subclasses.
    
    Co-authored-by: JGSweets <[email protected]>
    junholee6a and JGSweets authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    34dad6c View commit details
    Browse the repository at this point in the history
  2. Fix name mangling and typevar errors (capitalone#955)

    Inside the BaseDataProcessor class definition, references to
    __subclasses are automatically replaced with
    _BaseDataProcessor__subclasses. This remains the case even in static
    methods _register_subclass() and get_class(). Same with BaseModel and
    its __subclasses field. So we do not have to write out the full name
    mangled identifiers inside the class definitions.
    
    Also, mypy doesn't seem to be able to handle the return type of
    BaseDataProcessor.get_class() being a typevar, so that was changed to
    type[BaseDataProcessor]. This does not affect the functionality of
    get_class() since it always returns a subclass of BaseDataProcessor.
    junholee6a authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    5125af4 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. None-check labels dependants (capitalone#964)

    The mypy errors addressed here occur because variables label_mapping
    (in CharPreprocessor), unstructured_labels, and unstructured_label_set
    (in StructCharPreprocessor.process()) have optional types when they're
    used. This is fixed by checking that they are not None prior to the
    operation, which mypy recognizes as removing the None type from them.
    
    This should have no effect on functionality because we are already
    checking that labels is not None, and the variables above all depend on
    labels such that they are None only if labels is None.
    junholee6a authored Jul 20, 2023
    Configuration menu
    Copy the full SHA
    92346a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Changed publish-python-package.yml to include only release branches. (

    capitalone#965)
    
    * Changed release option to only release branches named \'release/<version-tag>\'.
    
    * Reverted types
    clee1152 authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    acb9c5e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Delay transforming priority_order into ndarray

    In the changed code, we had a mypy error because numpy ndarrays are not
    compatible with random.Random.shuffle() (expected argument type is
    MutableSequence[Any])
    
    We fix this by first instantiating priority_order as a list, then
    shuffling it, then creating an ndarray from it afterwards.
    junholee6a committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    36fc74a View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Configuration menu
    Copy the full SHA
    3ed3afc View commit details
    Browse the repository at this point in the history