Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial update to profile builder #1137

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Partial update to profile builder #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
300ca09
partial update to profile builder
atl1502 Apr 24, 2024
5a44acc
skip failing tests
atl1502 Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dataprofiler/profilers/base_column_profilers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from typing import Any, Callable, Generic, TypeVar

import numpy as np
import pandas as pd
import polars as pl

from . import profiler_utils
from .profiler_options import BaseInspectorOptions, BaseOption
Expand Down Expand Up @@ -97,7 +97,7 @@ def _filter_properties_w_options(
def _perform_property_calcs(
self,
calculations: dict,
df_series: pd.DataFrame,
df_series: pl.Series,
prev_dependent_properties: dict,
subset_properties: dict,
) -> None:
Expand Down Expand Up @@ -217,12 +217,12 @@ def __getitem__(self, item: str) -> Any:
return getattr(self, item)

@abc.abstractmethod
def _update_helper(self, df_series_clean: pd.DataFrame, profile: dict) -> None:
def _update_helper(self, df_series_clean: pl.Series, profile: dict) -> None:
"""Help update the profile."""
raise NotImplementedError()

@abc.abstractmethod
def update(self, df_series: pd.DataFrame) -> BaseColumnProfiler:
def update(self, df_series: pl.Series) -> BaseColumnProfiler:
"""
Update the profile.

Expand Down
Loading