update categorical profiler #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorfturner
suggested changes
Apr 24, 2024
| @@ -678,6 +681,9 @@ def update(self, df_series: Series) -> CategoricalColumn: | |||
| :return: updated CategoricalColumn | |||
| :rtype: CategoricalColumn | |||
| """ | |||
| # TODO remove onces profiler builder is updated | |||
| if type(df_series) == pd.Series: | |||
There was a problem hiding this comment.
Suggested change
| if type(df_series) == pd.Series: | |
| if isinstance(df_series, pd.Series): |
There was a problem hiding this comment.
you'll want to validate but this is a bit cleaner
Comment on lines
23
to
24
| maxDiff = None | ||
|
|
| @@ -883,7 +888,8 @@ def test_json_encode(self): | |||
| self.assertEqual(serialized, expected) | |||
|
|
|||
| def test_json_encode_after_update(self): | |||
| df_categorical = pd.Series( | |||
| df_categorical = pl.Series( | |||
| None, | |||
There was a problem hiding this comment.
why None outside []?
auto-merge was automatically disabled
April 24, 2024 17:55
Head branch was pushed to by a user without write access
taylorfturner
previously approved these changes
Apr 24, 2024
micdavis
reviewed
Apr 24, 2024
Comment on lines
606
to
607
| value_counts = df_series.value_counts(sort=True) | ||
| category_count: dict = dict(value_counts.iter_rows()) |
There was a problem hiding this comment.
Suggested change
| value_counts = df_series.value_counts(sort=True) | |
| category_count: dict = dict(value_counts.iter_rows()) | |
| category_count: dict = dict(df_series.value_counts(sort=True).iter_rows()) |
why not 1 line? Does this not run?
auto-merge was automatically disabled
April 24, 2024 19:25
Head branch was pushed to by a user without write access
micdavis
approved these changes
Apr 24, 2024
taylorfturner
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.