Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search with multiple values #753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

larslutz96
Copy link
Contributor

Fixes search for search terms with multiple values like: '/admin/Books?$search=foo bar'

@larslutz96 larslutz96 changed the title Fix search with multiple values fix: search with multiple values Jul 19, 2024
@BobdenOs
Copy link
Contributor

Please prevent duplicate or parallel work on the same task: #736

@johannes-vogel
Copy link
Contributor

Please prevent duplicate or parallel work on the same task: #736

I think that's a bit different. #736 was for sqlite and likely solved with #754.
This PR here likely provides compat for okra + cap-js/hana.

Copy link
Member

@patricebender patricebender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have a test for this?

@BobdenOs
Copy link
Contributor

@patricebender We had to disable the $search tests, because HXE doesn't support SCORE.

@danjoa
Copy link
Contributor

danjoa commented Jul 29, 2024

Didn't we say we simply pass search terms down to HANA?
If so, why do we need to process them?
Why are they xpr at all?

@llanghammer-sap
Copy link

Hey all,

Is there any update on this topic? On Fiori Element List Reports the Search is usually a standard feature and as of now any multi value search will result in an unexpected error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants