Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

refactor: replace asserts with exceptions #58

Merged
merged 2 commits into from
Jun 16, 2023
Merged

refactor: replace asserts with exceptions #58

merged 2 commits into from
Jun 16, 2023

Conversation

jpnurmi
Copy link
Contributor

@jpnurmi jpnurmi commented Jun 16, 2023

To make it possible to catch attempts navigating past boundaries which helps to implement nested wizards with asynchronous guards.

See also:

To make it possible to catch attempts navigating past boundaries.
@jpnurmi
Copy link
Contributor Author

jpnurmi commented Jun 16, 2023

Is this a feature, fix, refactor, or something else? :)

@jpnurmi jpnurmi requested a review from d-loose June 16, 2023 14:52
@jpnurmi jpnurmi changed the title feat: replace asserts with exceptions refactor: replace asserts with exceptions Jun 16, 2023
Copy link
Member

@d-loose d-loose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Is this a feature, fix, refactor, or something else? :)

I guess the best answer to that question is: 'yes' :D

@jpnurmi jpnurmi merged commit df8b73d into canonical:main Jun 16, 2023
@jpnurmi jpnurmi deleted the exception branch June 16, 2023 15:02
@github-actions github-actions bot mentioned this pull request Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants