include name in encoded token when using ListJoinTokens()
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoaggelos
requested review from
tomponline,
masnax,
roosterfish and
markylaing
as code owners
Signed-off-by: Angelos Kolaitis <[email protected]>
roosterfish
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Thanks, looks good to me. @masnax can you please double check?
|
Thanks, good catch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using
ListJoinTokens()the tokens do not match the join token that was given byNewJoinToken(), as it does not include the token name in the encoded string.Note that this does not affect joining nodes, as either of the tokens works (the
namefield of the token is not used).