Run PreRemove hook before modifying the database #107
Conversation
… the database Signed-off-by: Max Asnaashari <[email protected]>
…orwarding node The PreRemove hook might need to talk to the cluster so don't pre-emptively remove trust from any node until after we run the PreRemove hook Signed-off-by: Max Asnaashari <[email protected]>
masnax
requested review from
tomponline,
roosterfish and
markylaing
as code owners
|
I want to wait to merge this until after we have API updates in place, as this does affect the API. |
Which PR is this dependent on? |
I'm guessing #86, so an API extension can be added for it. |
|
Yes that was the case with all of the outstanding PRs since many were modifications to the API. But since @tomponline merged a bunch of them already I suppose it doesn't matter anymore. We can merge this as is. |
Well lets wait a moment - if the previous PRs I merged that were approved also need API extensions then lets also add them too. |
|
Its getting very hard to understand which PRs related to each other as so many are backed up. |
The PreRemove hook was intended to be used before the node was removed from the database, however it seems it was incorrectly only being run before the node was removed from dqlite.
This poses some issues because an application using microcluster may want to clean up entities associated to records in the database for a particular node, but by removing the node from the database first,
ON DELETE CASCADEwill clear all of that state.