Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxc: Handle sigkill in vga() properly to clean spice sockets and avoid accumulating them #14350

Merged
merged 1 commit into from
Oct 31, 2024
Merged

lxc: Handle sigkill in vga() properly to clean spice sockets and avoid accumulating them #14350

merged 1 commit into from
Oct 31, 2024

Conversation

gabrielmougard
Copy link
Contributor

closes #14241

simondeziel
simondeziel previously approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gabrielmougard
Copy link
Contributor Author

@tomponline this now uses signal.NotifyContext instead of signal.Notify

@gabrielmougard gabrielmougard force-pushed the fix/remove-spice-socket-properly branch 2 times, most recently from f77661e to b609044 Compare October 29, 2024 13:09
tomponline
tomponline reviewed Oct 29, 2024
View reviewed changes
lxc/console.go Outdated Show resolved Hide resolved
@gabrielmougard gabrielmougard force-pushed the fix/remove-spice-socket-properly branch 2 times, most recently from b721dbc to 36575f1 Compare October 30, 2024 08:15
tomponline
tomponline reviewed Oct 30, 2024
View reviewed changes
lxc/console.go Outdated Show resolved Hide resolved
tomponline
tomponline approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta!

@tomponline tomponline merged commit 144b7af into canonical:main Oct 31, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

@simondeziel simondeziel simondeziel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.spice Unix socket are left behind
3 participants
@gabrielmougard @tomponline @simondeziel