Switch back to the greeter when logind emits SecureAttentionKey #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3rdopolis
force-pushed
the
systemdrequestgreeter
branch
from
3fcfa92
to
57cf981
Compare
|
The failure seems to be |
|
systemd/systemd#29542 is now merged for v257 |
n3rdopolis
changed the title
|
@robert-ancell the change that this depended on just landed in logind. not sure if you want to wait until v257 though for it to make it to a stable release or not? |
n3rdopolis
changed the title
|
@robert-ancell I would like a review if possible please |
n3rdopolis
force-pushed
the
systemdrequestgreeter
branch
from
57cf981
to
557e30f
Compare
n3rdopolis
changed the title
|
@robert-ancell gentle ping |
|
@robert-ancell Gentle ping? Or are we waiting until systemd v257? |
|
@robert-ancell Systemd v257-rc1 has been tagged, do you think a review is possible please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on systemd/systemd#29542 which is going to be included in the upcoming systemd v257 release as it was merged