Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed untyped defs in cloudinit analyze #5823

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

abdulganiyy
Copy link

@abdulganiyy abdulganiyy commented Oct 14, 2024

Related to #5445

Proposed Commit Message

fix: fix untyped-defs in /analyze

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb holmanb added the CLA signed The submitter of the PR has signed the CLA label Oct 14, 2024
@holmanb
Copy link
Member

holmanb commented Oct 14, 2024

@abdulganiyy Thanks for this contribution!

Our CI jobs picked up that there is a syntax error in cloudinit/analyze/__init__.py. See the failed jobs for more detail.

@abdulganiyy
Copy link
Author

@abdulganiyy Thanks for this contribution!

Our CI jobs picked up that there is a syntax error in cloudinit/analyze/__init__.py. See the failed jobs for more detail.

Thank you. I’ll take a look at the failed CI jobs and review the syntax error. I'll follow up once I’ve identified and resolved the issue.

@abdulganiyy
Copy link
Author

@holmanb I have fixed the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed The submitter of the PR has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants