-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix arch systemd ordering cycle. #5819
Conversation
8f7f1ee
to
b4bc685
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is happy so i am happy :)
Thank you for adding detailed context in each commit message @holmanb.
Also I assume you would like to rebase and not squash (you have the squash merge checkbox selected atm)
Since After=sysinit.target is a default dependency, a cycle is introduced when Before=sysinit.target and not DefaultDependencies=no. Fixes canonicalGH-5755
A Before= on a single service doesn't need to exist in both cloud-init-main.service and cloud-init-local.service, because cloud-init-local.service and cloud-init-main.service are themselves ordered. Only one requires it. The same applies for After=.
b4bc685
to
91deb08
Compare
Should the rest of the OSes in the first section be extended to the 2nd section? Since it was part of the larger service file earlier, I would think yes for any distro that has |
+1 to the 2nd commit |
This ordering was inherited from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the extra context.
Since After=sysinit.target is a default dependency, a cycle is introduced when Before=sysinit.target and not DefaultDependencies=no. Fixes GH-5755
Since After=sysinit.target is a default dependency, a cycle is introduced when Before=sysinit.target and not DefaultDependencies=no. Fixes canonicalGH-5755
A Before= on a single service doesn't need to exist in both cloud-init-main.service and cloud-init-local.service, because cloud-init-local.service and cloud-init-main.service are themselves ordered. Only one requires it. The same applies for After=.
A Before= on a single service doesn't need to exist in both cloud-init-main.service and cloud-init-local.service, because cloud-init-local.service and cloud-init-main.service are themselves ordered. Only one requires it. The same applies for After=.
Proposed Commit Message
See individual commits. One is a fix for #5755 and the other cleans up redundant dependencies that were introduced in the single process change.
Merge type