Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update netplan import semantics and related tests #5805

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

TheRealFalcon
Copy link
Member

@TheRealFalcon TheRealFalcon commented Oct 9, 2024

Proposed Commit Message

chore: update netplan import semantics and related tests

The way the netplan API was being imported caused test issues.
Imports were moved and tests updated accordingly.

Fixes GH-5804

Additional Context

To reproduce in a virtualenv, symlink the netplan API (should be at /usr/lib/python3/dist-packages/netplan) into your virtualenv's site-packages.

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

The way the netplan API was being imported caused test issues.
Imports were moved and tests updated accordingly.

Fixes canonicalGH-5804
Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackboxsw blackboxsw merged commit 40f9bae into canonical:main Oct 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants