Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto label doc PRs #5542

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: auto label doc PRs #5542

merged 1 commit into from
Jul 24, 2024

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Jul 24, 2024

Proposed Commit Message

fix: auto label doc PRs

Create explicit file to define and pin the actions/labeler's version.

Upgrade breaking changes from action/labeler@v5.

Additional Context

The current action should label PRs with changes under doc/ as documentation but it does not, see: https://github.com/canonical/cloud-init/actions/runs/10078086430/job/27862171756?pr=5541.

https://github.com/actions/labeler?tab=readme-ov-file#breaking-changes-in-v5
https://github.com/actions/labeler/releases/tag/v5.0.0

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Create explicit file to define and pin the actions/labeler's version.

Upgrade breaking changes from action/labeler@v5.
@s-makin s-makin added the documentation This Pull Request changes documentation label Jul 24, 2024
Copy link
Collaborator

@a-dubs a-dubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we love automations!!!

@holmanb holmanb merged commit bb4b7c0 into canonical:main Jul 24, 2024
23 checks passed
@aciba90 aciba90 deleted the fix-labeler-action branch July 25, 2024 07:18
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Aug 2, 2024
Create explicit file to define and pin the actions/labeler's version.

Upgrade breaking changes from action/labeler@v5.
holmanb pushed a commit that referenced this pull request Aug 6, 2024
Create explicit file to define and pin the actions/labeler's version.

Upgrade breaking changes from action/labeler@v5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This Pull Request changes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants