Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu/devel #4471

Closed
wants to merge 2 commits into from
Closed

Conversation

blackboxsw
Copy link
Collaborator

do not squash merge

Queue Recommends dependency on python3-apt for apt_pkg module since cc_apt_configure uses it for some operations.
Cloud-init falls back to apt-config dump command when python module not present.

When this PR is merged, I will reflect it to Focal/Jammy/Lunar branches

Proposed commit messages

update changelog
    d/contol: add python3-apt to Recommends
    
    cc_apt_configure will use apt_pkg from this deb if present to
    read apt configuration for Dir::Etc::sourceparts/sourcelist values.
    
    When absent, rely on the command apt-config dump.

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Commit 612b4de introduced parse_cmdline function which did not account for
hyphenated datasource names.

This negatively impacted the detection of hyphenated nocloud-net.

Fix parse_cmdline regex to align with ds-identify logic which matches all
characters until either a semi-colon or whitespace.

Extend integration tests to consume github flat files as the seed_from URL.
setup and consume user-data, meta-data from using github raw files as the seed

Fixes: 4203
@blackboxsw blackboxsw changed the base branch from main to ubuntu/devel September 28, 2023 19:50
@blackboxsw blackboxsw closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant