Cleanup Logging Configuration #4435

holmanb · 2023-09-14T22:56:45Z

Please merge as individual commits.

Additional Context

cloud-init's log module implements a wrapper for logging.getLogger,
however this module is not consistently used across the codebase. Furthermore
most of these invocations choose to alias cloudinit.log module to logging.
Shadowing a standard library module, and especially doing so inconsistently
across the codebase, is not best practice. Since this wrapper doesn't add
value, replace all invocations with the standard library call.

Delete unnecessary log module wrapper.

Also standardize logger names to use logging.getLogger(__name__).

cloudinit/log.py

TheRealFalcon

Great refactor overall. I left some comments inline.

One more possible improvement (which we can probably do later since this PR is already huge): most of the camelCase functions in log.py don't have many call sites and could be converted to snake_case.

Also, since we plan on keeping all the commits, for ease of later review, please add new commits that can later be squashed/rebased rather amending any current ones.

TheRealFalcon · 2023-09-19T21:07:42Z

cloudinit/log.py

@@ -130,10 +130,6 @@ def setupLogging(cfg=None):
        setupBasicLogging()


-def getLogger(name="cloudinit"):


getLogger will return the "cloudinit" logger if nothing is passed to it. That was getting reset in resetLogging(), but now there is nothing resetting it.

Was that an oversight, or by "unused" (in the commit message) do you mean that the "cloudinit" logger has not been used yet? If so, lets add info to the commit message explaining that.

do you mean that the "cloudinit" logger has not been used yet?

Correct

If so, lets add info to the commit message explaining that.

Will do

TheRealFalcon · 2023-09-19T21:28:24Z

cloudinit/log.py

@@ -16,17 +16,13 @@
 import os
 import sys
 import time
-
-# Default basic format
-DEF_CON_FORMAT = "%(asctime)s - %(filename)s[%(levelname)s]: %(message)s"


Even if only used twice, this definition seems more like a magic value, and we don't want one changing without the other, so I think it makes sense to keep it defined here. Though we could maybe rename to DEFAULT_LOG_FORMAT or something.

Agreed and fixed

TheRealFalcon · 2023-09-19T21:33:37Z

cloudinit/log.py

+        # The default configuration includes an attempt at using /dev/log,
+        # followed up by writing to a file. /dev/log will not exist in
+        # very early boot, so an exception on that is expected.
+        with suppress(Exception):


I know the old version used Exception, but any chance we can add a more specific exception here?

I was thinking about that too. FileNotFound looks to be the exception described in the comments:

>>> import logging.config >>> logging.config.fileConfig("/tasoeinf") Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib/python3.11/logging/config.py", line 65, in fileConfig raise FileNotFoundError(f"{fname} doesn't exist") FileNotFoundError: /tasoeinf doesn't exist

TheRealFalcon · 2023-09-19T21:52:36Z

cloudinit/log.py

@@ -136,4 +128,33 @@ def resetLogging():
    log.addHandler(logging.NullHandler())


-resetLogging()
+def setup_backup_logging():


Do we have tests for the old patcher behavior? If not, let's make sure this is tested and works as expected.

Indirectly, yes.

Some of our unit tests depend on caplog picking up stderr output which formerly got set up by patcher.patch_logging(), and now gets set up by setup_backup_logging().

This can be seen by running unit tests against main with the following diff:

git diff | cat diff --git a/cloudinit/cmd/main.py b/cloudinit/cmd/main.py index 21e994776..963b395c6 100755 --- a/cloudinit/cmd/main.py +++ b/cloudinit/cmd/main.py @@ -26,7 +26,6 @@ from typing import Tuple from cloudinit import patcher from cloudinit.config.modules import Modules -patcher.patch_logging() from cloudinit.config.schema import validate_cloudconfig_schema from cloudinit import log as logging

Which yields:

================================================================================== short test summary info =================================================================================== FAILED tests/unittests/config/test_schema.py::TestMain::test_main_absent_config_file - assert 'Error: Config file NOT_A_FILE does not exist\n' == '--- Logging error ---\nTraceback (most recent call last):\n File "/usr/lib/python3.11/logging/__init__.py", line 1113, in em... FAILED tests/unittests/config/test_schema.py::TestMain::test_main_system_userdata_requires_root - assert 'Error:\nUnable to read system userdata or vendordata as non-root user. Try using sudo.\n' == '--- Logging error ---\nTraceback (most recent call last):\n File "/usr/lib/python3... FAILED tests/unittests/config/test_schema.py::TestHandleSchemaArgs::test_handle_schema_args_annotate_deprecated_config[True-#cloud-config\npackages:\n- htop\napt_update: true # D1\napt_upgrade: true # D2\napt_reboot_if_required: true # D3\n\n# Deprecations: -------------\n# D1: Default: ``false``. Deprecated in version 22.2. Use ``package_update`` instead.\n# D2: Default: ``false``. Deprecated in version 22.2. Use ``package_upgrade`` instead.\n# D3: Default: ``false``. Deprecated in version 22.2. Use ``package_reboot_if_required`` instead.\n\nValid cloud-config: {cfg_file}\n] - assert not '--- Logging error ---\nTraceback (most recent call last):\n File "/usr/lib/python3.11/logging/__init__.py", line 1113, in emit\n stream.write(msg + self.terminator)\nVal... FAILED tests/unittests/config/test_schema.py::TestHandleSchemaArgs::test_handle_schema_args_annotate_deprecated_config[False-Cloud config schema deprecations: apt_reboot_if_required: Default: ``false``. Deprecated in version 22.2. Use ``package_reboot_if_required`` instead., apt_update: Default: ``false``. Deprecated in version 22.2. Use ``package_update`` instead., apt_upgrade: Default: ``false``. Deprecated in version 22.2. Use ``package_upgrade`` instead. Valid cloud-config: {cfg_file}\n] - assert not '--- Logging error ---\nTraceback (most recent call last):\n File "/usr/lib/python3.11/logging/__init__.py", line 1113, in emit\n stream.write(msg + self.terminator)\nVal... FAILED tests/unittests/config/test_schema.py::TestHandleSchemaArgs::test_handle_schema_args_jinja_with_errors[root_annotate_unique_errors_no_exception] - assert '' == '--- Logging error ---\nTraceback (most recent call last):\n File "/usr/lib/python3.11/logging/__init__.py", line 1113, in emit\n stream.write(msg + self.terminator)\nV... FAILED tests/unittests/config/test_schema.py::TestHandleSchemaArgs::test_handle_schema_args_jinja_with_errors[root_no_annotate_exception_with_unique_errors] - assert "Error: Cloud config schema errors: hostname: 123 is not of type 'string'\n\nError: Invalid cloud-config schema: user-data\n\n" == '--- Logging error ---\nTraceback (most recent ... ================================================ 6 failed, 4870 passed, 4 skipped, 1 deselected, 1 xfailed, 281 warnings in 122.15s (0:02:02) ================================================

I would expect these to also fail against this branch too if this implementation was incorrect.

Just to be sure, I double checked this on an instance.

# first create an instance named me, then lxc storage create small btrfs lxc storage set small volume.size=100KiB lxc storage volume create small smallvol lxc storage volume attach small smallvol me /small lxc shell me cloud-init clean --logs touch /small/cloud-init.log cd /var/log rm cloud-init.log ln -s /small/cloud-init.log cloud-init init --local # keep going through services until you see fallback logs show up

Small snippet:

root@me:/var/log# cloud-init init Cloud-init v. 23.3.1 running 'init' at Wed, 20 Sep 2023 13:37:12 +0000. Up 179.86 seconds. ci-info: +++++++++++++++++++++++++++++++++++++++++++++Net device info++++++++++++++++++++++++++++++++++++++++++++++ ci-info: +--------+------+-------------------------------------------+---------------+--------+-------------------+ ci-info: | Device | Up | Address | Mask | Scope | Hw-Address | ci-info: +--------+------+-------------------------------------------+---------------+--------+-------------------+ ci-info: | eth0 | True | 10.197.203.247 | 255.255.255.0 | global | 00:16:3e:df:1d:bf | ci-info: | eth0 | True | fd42:eaab:10a1:ad48:216:3eff:fedf:1dbf/64 | . | global | 00:16:3e:df:1d:bf | ci-info: | eth0 | True | fe80::216:3eff:fedf:1dbf/64 | . | link | 00:16:3e:df:1d:bf | ci-info: | lo | True | 127.0.0.1 | 255.0.0.0 | host | . | ci-info: | lo | True | ::1/128 | . | host | . | ci-info: +--------+------+-------------------------------------------+---------------+--------+-------------------+ ci-info: +++++++++++++++++++++++++++++++Route IPv4 info+++++++++++++++++++++++++++++++ ci-info: +-------+--------------+--------------+-----------------+-----------+-------+ ci-info: | Route | Destination | Gateway | Genmask | Interface | Flags | ci-info: +-------+--------------+--------------+-----------------+-----------+-------+ ci-info: | 0 | 0.0.0.0 | 10.197.203.1 | 0.0.0.0 | eth0 | UG | ci-info: | 1 | 10.197.203.0 | 0.0.0.0 | 255.255.255.0 | eth0 | U | ci-info: | 2 | 10.197.203.1 | 0.0.0.0 | 255.255.255.255 | eth0 | UH | ci-info: +-------+--------------+--------------+-----------------+-----------+-------+ ci-info: ++++++++++++++++++++++++++++++++++Route IPv6 info++++++++++++++++++++++++++++++++++ ci-info: +-------+--------------------------+--------------------------+-----------+-------+ ci-info: | Route | Destination | Gateway | Interface | Flags | ci-info: +-------+--------------------------+--------------------------+-----------+-------+ ci-info: | 0 | fd42:eaab:10a1:ad48::/64 | :: | eth0 | U | ci-info: | 1 | fe80::/64 | :: | eth0 | U | ci-info: | 2 | ::/0 | fe80::216:3eff:fede:84e6 | eth0 | UGe | ci-info: | 4 | local | :: | eth0 | U | ci-info: | 5 | local | :: | eth0 | U | ci-info: | 6 | multicast | :: | eth0 | U | ci-info: +-------+--------------------------+--------------------------+-----------+-------+ FALLBACK: 2023-09-20 13:37:13,110 - util.py[DEBUG]: Attempting to load yaml from string of length 18 with allowed root types (<class 'dict'>,) FALLBACK: 2023-09-20 13:37:13,112 - cloud_config.py[DEBUG]: Merging by applying [('dict', ['replace']), ('list', []), ('str', [])] FALLBACK: 2023-09-20 13:37:13,114 - __init__.py[DEBUG]: Calling handler CloudConfigPartHandler: [['text/cloud-config', 'text/cloud-config-jsonp']] (__end__, None, 3) with frequency once-per-instance FALLBACK: 2023-09-20 13:37:13,116 - util.py[DEBUG]: Writing to /var/lib/cloud/instances/me/vendor-cloud-config.txt - wb: [600] 53 bytes FALLBACK: 2023-09-20 13:37:13,118 - __init__.py[DEBUG]: Calling handler ShellScriptPartHandler: [['text/x-shellscript']] (__end__, None, 2) with frequency once-per-instance FALLBACK: 2023-09-20 13:37:13,119 - __init__.py[DEBUG]: Calling handler ShellScriptByFreqPartHandler: [['text/x-shellscript-per-boot']] (__end__, None, 2) with frequency once-per-instance FALLBACK: 2023-09-20 13:37:13,120 - __init__.py[DEBUG]: Calling handler ShellScriptByFreqPartHandler: [['text/x-shellscript-per-instance']] (__end__, None, 2) with frequency once-per-instance FALLBACK: 2023-09-20 13:37:13,122 - __init__.py[DEBUG]: Calling handler ShellScriptByFreqPartHandler: [['text/x-shellscript-per-once']] (__end__, None, 2) with frequency once-per-instance FALLBACK: 2023-09-20 13:37:13,123 - __init__.py[DEBUG]: Calling handler BootHookPartHandler: [['text/cloud-boothook']] (__end__, None, 2) with frequency once-per-instance FALLBACK: 2023-09-20 13:37:13,125 - __init__.py[DEBUG]: Calling handler JinjaTemplatePartHandler: [['text/jinja2']] (__end__, None, 3) with frequency once-per-instance FALLBACK: 2023-09-20 13:37:13,126 - handlers.py[DEBUG]: finish: init-network/consume-vendor-data: SUCCESS: reading and applying vendor-data FALLBACK: 2023-09-20 13:37:13,128 - handlers.py[DEBUG]: start: init-network/consume-vendor-data2: reading and applying vendor-data2 FALLBACK: 2023-09-20 13:37:13,130 - stages.py[DEBUG]: no vendordata2 from datasource FALLBACK: 2023-09-20 13:37:13,131 - handlers.py[DEBUG]: finish: init-network/consume-vendor-data2: SUCCESS: reading and applying vendor-data2 FALLBACK: 2023-09-20 13:37:13,133 - util.py[DEBUG]: Reading from /etc/cloud/cloud.cfg (quiet=False) FALLBACK: 2023-09-20 13:37:13,134 - util.py[DEBUG]: Read 3758 bytes from /etc/cloud/cloud.cfg

Also saw these fallback logs get redirected to cloud-init-output.log

+1

TheRealFalcon · 2023-09-19T21:53:24Z

cloudinit/log.py

+    logging.Handler.handleError = handleError
+
+
+def configure_root_logger():


This is WAY nicer than before 😃

TheRealFalcon · 2023-09-19T21:59:41Z

cloudinit/cmd/devel/hotplug_hook.py

@@ -16,7 +17,7 @@
 from cloudinit.sources import DataSource, DataSourceNotFoundException
 from cloudinit.stages import Init

-LOG = log.getLogger(__name__)
+LOG = logging.getLogger(__name__)


Missed removing the log import on this one

Nope! log gets used on line 250.

TheRealFalcon · 2023-09-19T22:01:34Z

cloudinit/cmd/devel/net_convert.py

@@ -4,6 +4,7 @@
 """Debug network config format conversions."""
 import argparse
 import json
+import logging


If this is the only change, did we just have broken code in this module previously?

Nice catch, it looks like the rest of this change slipped into a separate commit. I'll fix that.

holmanb · 2023-09-19T23:33:28Z

Thanks for the review @TheRealFalcon. I believe that I've addressed all of your comments.

One more possible improvement (which we can probably do later since this PR is already huge): most of the camelCase functions in log.py don't have many call sites and could be converted to snake_case.

I was thinking about that too. I'll include a separate PR for that.

Also, since we plan on keeping all the commits, for ease of later review, please add new commits that can later be squashed/rebased rather amending any current ones.

I added the logging exception change as a separate logical commit, and the rest were included using git commit --fixup. After review and prior to merge we will do a git rebase --interactive --autosquash main. Let me know if you have any questions.

TheRealFalcon

LGTM!

I'll leave it to you to merge. Let's wait until after we're sure how we want to handle these sorts of commits in the ChangeLog.

holmanb · 2023-09-20T15:04:37Z

LGTM!

I'll leave it to you to merge. Let's wait until after we're sure how we want to handle these sorts of commits in the ChangeLog.

Thanks for the review. Per our discussion out of band, I'll update the commit messages to include the PR number and then (after autosquashing the fixups), I'll do a rebase and merge.

cloudinit.log: Use more appropriate exception (canonical#4435) cloud-init's logging code has for a long time caught and ignored a bare Exception. Use a more specific exception for the expected case that this handles.

cloudinit.log: Don't configure NullHandler (canonical#4435) NullHandler hasn't been required to prevent the logging warnings since commit 5a27d4018 landed in Python, which was released in Python 3.2.

cloudinit.log: Remove unused getLogger wrapper (canonical#4435) This wrapper provided a default logger with name "cloudinit" when called without arguments. This behavior was never used and can safely be removed.

Simplify root logger configuration (canonical#4435) The root logger gets configured at various stages of cloudinit execution. Some changes occur while importing cloudinit.log, which causes side effects in any project using cloudinit as a library (Ubuntu Pro, etc). These modifications do not require change during runtime and can take place as an early setup task in cloudinit.cmd.main::main(). Simplify this code, relocate logger configuration code to a function in cloudinit.log, set the callsite in cloudinit.cmd.main::main(). Also add context to logging configuration code.

cloudinit.log: Remove unnecessary module function and variables (canonical#4435)

cloudinit.log: Standardize use of cloudinit's logging module (canonical#4435) cloud-init's log module implements a wrapper for logging.getLogger, however this module is not consistently used across the codebase. Furthermore most of these invocations choose to alias cloudinit.log module to logging. Shadowing a standard library module, and especially doing so inconsistently across the codebase, is not best practice. Since this wrapper doesn't add value, replace all invocations with the standard library call. Also standardize logger names to use logging.getLogger(__name__).

Remove unnecessary logging wrapper in Cloud class (canonical#4435) Cloud.cycle_logging() is only called once in the codebase, and its only benefit is turning two function calls into a single call. Remove it.

Cloud.cycle_logging() is only called once in the codebase, and its only benefit is turning two function calls into a single call. Remove it.

…al#4435) cloud-init's log module implements a wrapper for logging.getLogger, however this module is not consistently used across the codebase. Furthermore most of these invocations choose to alias cloudinit.log module to logging. Shadowing a standard library module, and especially doing so inconsistently across the codebase, is not best practice. Since this wrapper doesn't add value, replace all invocations with the standard library call. Also standardize logger names to use logging.getLogger(__name__).

This wrapper provided a default logger with name "cloudinit" when called without arguments. This behavior was never used and can safely be removed.

holmanb · 2023-09-20T19:52:59Z

As a reference for others, here is an unsquashed copy of this branch before autosquashing

Then steps taken:

git rebase --interactive --autosquash
git push --force
# wait for tests to pass
# rebase merge

…nical#4435)

The root logger gets configured at various stages of cloudinit execution. Some changes occur while importing cloudinit.log, which causes side effects in any project using cloudinit as a library (Ubuntu Pro, etc). These modifications do not require change during runtime and can take place as an early setup task in cloudinit.cmd.main::main(). Simplify this code, relocate logger configuration code to a function in cloudinit.log, set the callsite in cloudinit.cmd.main::main(). Also add context to logging configuration code.

NullHandler hasn't been required to prevent the logging warnings since commit 5a27d4018 landed in Python, which was released in Python 3.2.

cloud-init's logging code has for a long time caught and ignored a bare Exception. Use a more specific exception for the expected case that this handles.

canonical#4435)

holmanb · 2023-09-20T20:35:45Z

@TheRealFalcon I botched one of the s/log/logging/g changes in the fixup, which was revealed by tests after pushing the autosquashed version. I pushed one last fixup commit for review. It is a trivial change.

…nical#4435)

The root logger gets configured at various stages of cloudinit execution. Some changes occur while importing cloudinit.log, which causes side effects in any project using cloudinit as a library (Ubuntu Pro, etc). These modifications do not require change during runtime and can take place as an early setup task in cloudinit.cmd.main::main(). Simplify this code, relocate logger configuration code to a function in cloudinit.log, set the callsite in cloudinit.cmd.main::main(). Also add context to logging configuration code.

NullHandler hasn't been required to prevent the logging warnings since commit 5a27d4018 landed in Python, which was released in Python 3.2.

cloud-init's logging code has for a long time caught and ignored a bare Exception. Use a more specific exception for the expected case that this handles.

Cloud.cycle_logging() is only called once in the codebase, and its only benefit is turning two function calls into a single call. Remove it.

cloud-init's log module implements a wrapper for logging.getLogger, however this module is not consistently used across the codebase. Furthermore most of these invocations choose to alias cloudinit.log module to logging. Shadowing a standard library module, and especially doing so inconsistently across the codebase, is not best practice. Since this wrapper doesn't add value, replace all invocations with the standard library call. Also standardize logger names to use logging.getLogger(__name__).

This wrapper provided a default logger with name "cloudinit" when called without arguments. This behavior was never used and can safely be removed.

The root logger gets configured at various stages of cloudinit execution. Some changes occur while importing cloudinit.log, which causes side effects in any project using cloudinit as a library (Ubuntu Pro, etc). These modifications do not require change during runtime and can take place as an early setup task in cloudinit.cmd.main::main(). Simplify this code, relocate logger configuration code to a function in cloudinit.log, set the callsite in cloudinit.cmd.main::main(). Also add context to logging configuration code.

NullHandler hasn't been required to prevent the logging warnings since commit 5a27d4018 landed in Python, which was released in Python 3.2.

holmanb force-pushed the holmanb/cleanup-logging-callsites branch from 3fed267 to 8a2c08e Compare September 14, 2023 23:15

holmanb requested a review from TheRealFalcon September 15, 2023 00:27

holmanb changed the title ~~Cleanup Logging Callsites~~ WIP: Cleanup Logging Configuration Sep 15, 2023

TheRealFalcon reviewed Sep 15, 2023

View reviewed changes

cloudinit/log.py Outdated Show resolved Hide resolved

holmanb added the wip Work in progress, do not land label Sep 15, 2023

holmanb force-pushed the holmanb/cleanup-logging-callsites branch 2 times, most recently from 2118764 to 7362945 Compare September 18, 2023 21:17

holmanb changed the title ~~WIP: Cleanup Logging Configuration~~ Cleanup Logging Configuration Sep 18, 2023

holmanb removed the wip Work in progress, do not land label Sep 18, 2023

holmanb requested a review from TheRealFalcon September 18, 2023 21:38

TheRealFalcon self-assigned this Sep 19, 2023

TheRealFalcon requested changes Sep 19, 2023

View reviewed changes

holmanb requested a review from TheRealFalcon September 19, 2023 23:33

holmanb mentioned this pull request Sep 19, 2023

Make logging snakecase #4449

Merged

TheRealFalcon approved these changes Sep 20, 2023

View reviewed changes

holmanb added a commit to holmanb/cloud-init that referenced this pull request Sep 20, 2023

amend! cloudinit.log: Remove unnecessary module function and variables

5ad76fd

cloudinit.log: Remove unnecessary module function and variables (canonical#4435)

holmanb added 3 commits September 20, 2023 13:52

Remove unnecessary logging wrapper in Cloud class (canonical#4435)

3434db7

Cloud.cycle_logging() is only called once in the codebase, and its only benefit is turning two function calls into a single call. Remove it.

cloudinit.log: Remove unused getLogger wrapper (canonical#4435)

0ce9acf

This wrapper provided a default logger with name "cloudinit" when called without arguments. This behavior was never used and can safely be removed.

holmanb added a commit to holmanb/cloud-init that referenced this pull request Sep 20, 2023

cloudinit.log: Remove unnecessary module function and variables (cano…

ac1dcbf

…nical#4435)

holmanb force-pushed the holmanb/cleanup-logging-callsites branch from 7487342 to 3a9c178 Compare September 20, 2023 19:53

holmanb added a commit to holmanb/cloud-init that referenced this pull request Sep 20, 2023

fixup! cloudinit.log: Remove unnecessary module function and variables (

4adaa91

canonical#4435)

TheRealFalcon approved these changes Sep 20, 2023

View reviewed changes

holmanb added 4 commits September 20, 2023 17:18

cloudinit.log: Remove unnecessary module function and variables (cano…

f9d7b61

…nical#4435)

cloudinit.log: Don't configure NullHandler (canonical#4435)

0d99945

NullHandler hasn't been required to prevent the logging warnings since commit 5a27d4018 landed in Python, which was released in Python 3.2.

cloudinit.log: Use more appropriate exception (canonical#4435)

b13037c

cloud-init's logging code has for a long time caught and ignored a bare Exception. Use a more specific exception for the expected case that this handles.

holmanb force-pushed the holmanb/cleanup-logging-callsites branch from 4adaa91 to b13037c Compare September 20, 2023 23:22

holmanb merged commit 107aa74 into canonical:main Sep 21, 2023
26 checks passed

holmanb added a commit that referenced this pull request Sep 21, 2023

Remove unnecessary logging wrapper in Cloud class (#4435)

461f261

Cloud.cycle_logging() is only called once in the codebase, and its only benefit is turning two function calls into a single call. Remove it.

holmanb added a commit that referenced this pull request Sep 21, 2023

cloudinit.log: Remove unused getLogger wrapper (#4435)

40bfa35

This wrapper provided a default logger with name "cloudinit" when called without arguments. This behavior was never used and can safely be removed.

holmanb added a commit that referenced this pull request Sep 21, 2023

cloudinit.log: Remove unnecessary module function and variables (#4435)

b032615

holmanb added a commit that referenced this pull request Sep 21, 2023

cloudinit.log: Don't configure NullHandler (#4435)

de472d0

NullHandler hasn't been required to prevent the logging warnings since commit 5a27d4018 landed in Python, which was released in Python 3.2.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup Logging Configuration #4435

Cleanup Logging Configuration #4435

holmanb commented Sep 14, 2023 •

edited

Loading

TheRealFalcon left a comment

TheRealFalcon Sep 19, 2023 •

edited

Loading

holmanb Sep 19, 2023

TheRealFalcon Sep 19, 2023

holmanb Sep 19, 2023

TheRealFalcon Sep 19, 2023

holmanb Sep 19, 2023

TheRealFalcon Sep 19, 2023

holmanb Sep 19, 2023

TheRealFalcon Sep 20, 2023

TheRealFalcon Sep 19, 2023

holmanb Sep 19, 2023

TheRealFalcon Sep 19, 2023

holmanb Sep 19, 2023

TheRealFalcon Sep 19, 2023

holmanb Sep 19, 2023 •

edited

Loading

holmanb commented Sep 19, 2023

TheRealFalcon left a comment

holmanb commented Sep 20, 2023

holmanb commented Sep 20, 2023

holmanb commented Sep 20, 2023

		@@ -130,10 +130,6 @@ def setupLogging(cfg=None):
		setupBasicLogging()


		def getLogger(name="cloudinit"):

		logging.Handler.handleError = handleError


		def configure_root_logger():

Cleanup Logging Configuration #4435

Cleanup Logging Configuration #4435

Conversation

holmanb commented Sep 14, 2023 • edited Loading

Additional Context

TheRealFalcon left a comment

Choose a reason for hiding this comment

TheRealFalcon Sep 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

holmanb Sep 19, 2023 • edited Loading

Choose a reason for hiding this comment

holmanb commented Sep 19, 2023

TheRealFalcon left a comment

Choose a reason for hiding this comment

holmanb commented Sep 20, 2023

holmanb commented Sep 20, 2023

holmanb commented Sep 20, 2023

holmanb commented Sep 14, 2023 •

edited

Loading

TheRealFalcon Sep 19, 2023 •

edited

Loading

holmanb Sep 19, 2023 •

edited

Loading