[jammy] patch: Retain old groups in default user template #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holmanb
changed the title
TheRealFalcon
requested changes
Jul 20, 2023
|
@TheRealFalcon Thanks for the review. I'll open against lunar and focal once this is approved. |
|
Sorry, didn't really look super thoroughly the last time. I think we need an upstream snapshot first. How can we have a patch against code that doesn't actually exist yet in the branch? After that, we need to generate a quilt patch, not just a diff. It needs a DEP-3 header and a reference in See https://github.com/canonical/uss-tableflip/blob/main/doc/ubuntu_release_process.md#adding-a-quilt-patch-to-debianpatches (or https://wiki.debian.org/UsingQuilt). |
Merged
|
If #4286 merges we can close this one |
|
Closing as it was incorporated in #4286 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Context
I just merged #4258, for which this patch retains old behavior.
https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1923363