build: reorganize build metadata (#549) #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
reviewed
Mar 22, 2024
| @@ -132,7 +133,7 @@ lint.fixable = [ | |||
| # W191 - tab-indentation* | |||
| # PGH003 - blanket-type-ignore | |||
| # *ignored for compatibility with formatter | |||
| lint.ignore = [ | |||
There was a problem hiding this comment.
Did you not get warnings after removing this?
There was a problem hiding this comment.
It's a minor change, but in the template (https://github.com/GenomicMedLab/software-templates/blob/05c35343641086045f3c6205a2ebe7524f28d1be/python/%7B%7Bcookiecutter.project_slug%7D%7D/pyproject.toml#L69) I just have a separate primary TOML section for tool.ruff.lint rather than making each of the lint subsections live under tool.ruff (I don't think there's a functional change? unless I missed something?)
There was a problem hiding this comment.
(line 76 being where the new section is added here)
korikuzma
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.