Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle cases where gene_context is not found #536

Merged
merged 10 commits into from
Feb 13, 2024
Merged

fix: handle cases where gene_context is not found #536

merged 10 commits into from
Feb 13, 2024

Conversation

korikuzma
Copy link
Member

close #535

  • Also handles cases where only protein or cdna gene is found and adds warnings if there is a mismatch when both exist. Haven't found an example of where a mismatch occurs, but once I do I can add a test for it.

@korikuzma
build: update cool-seq-tool + ga4gh.vrs versions
84fe73d
@korikuzma
temp remove gnomad_vcf_to_protein
52855ab
@korikuzma
style: use ruff == 0.2.0
5729291
@korikuzma
Merge branch 'main' into issue-530
5ea18dd
@korikuzma
resolve noqa
716c3d9
@korikuzma
build: modernize build configs
22c16c4 
* Use the "src" layout instead of a "flat" layout
* Move build settings into pyproject.toml
@korikuzma
ruff fix
2b3a492
@korikuzma
fix: handle cases where gene_context is not found
65740f1 
* Also handles cases where only protein or cdna gene is found and adds
  warnings if there is a mismatch when both exist
@korikuzma
define gene
b504f4c
@korikuzma korikuzma added bug Something isn't working priority:high High priority labels Feb 13, 2024
@korikuzma korikuzma self-assigned this Feb 13, 2024
katiestahl
katiestahl previously approved these changes Feb 13, 2024
View reviewed changes
Base automatically changed from issue-531 to main February 13, 2024 21:29
@korikuzma korikuzma dismissed katiestahl’s stale review February 13, 2024 21:29

The base branch was changed.

@korikuzma korikuzma merged commit 0cf8881 into main Feb 13, 2024
10 checks passed
@korikuzma korikuzma deleted the issue-535 branch February 13, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katiestahl katiestahl katiestahl left review comments

Assignees

@korikuzma korikuzma

Labels
bug Something isn't working priority:high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gnomad_vcf_to_protein handle cases where no gene is found
2 participants
@korikuzma @katiestahl