Started updating GDC to CCDH conversion to use crdch_model #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sujaypatil96 This is the work I previously did on converting the GDC-to-CRDCH Jupyter Notebook to use the crdch_model from PyPI, but I didn't manage to fully finish it. I think I'll wait until you're done with the PDC-to-CRDCH Jupyter Notebook, and then I'll steal some ideas from you from that project :) |
|
These changes have already been made in PR #48, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts the process of updating the GDC to CCDH conversion Jupyter Notebook to use crdch_model rather than the using the
ccdh/ccdhmodel.pyfile included in this repo. Since there have been some major changes to the model since that release, this will require the code to be updated as well.WIP: Apart from fully converting this Jupyter Notebook, this PR should try to create a GitHub Action (#18) to ensure that all included Jupyter Notebooks are executable without any errors.
Closes #25.