Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport stable/8.2] Properly support Signal broadcasting #969

Merged
4 commits merged into from
Nov 9, 2023
Merged

[Backport stable/8.2] Properly support Signal broadcasting #969

4 commits merged into from
Nov 9, 2023

Conversation

remcowesterhoud
Copy link
Contributor

Description

Backport of #966 to stable/8.2.

relates to #964

@remcowesterhoud
test: verify broadcasting of signals
280b235 
Verify we can broadcast signals and retrieve a response with a key

(cherry picked from commit 766a700)
@remcowesterhoud
fix: don't set variables if empty
b6ea7f6 
If the variables are empty we cannot convert them to MsgPack. Instead, we should ignore them and not add them to the record.

(cherry picked from commit 77901f4)
@remcowesterhoud
fix: map signal response
2a7ec55 
Maps a response for signals. The response from the gateway contains the key and the tenant id.

I left the tenant id out for now as it's not yet supported in ZPT

(cherry picked from commit e10a176)
nicpuppa
nicpuppa approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@nicpuppa nicpuppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

ghost pushed a commit that referenced this pull request Nov 9, 2023
@remcowesterhoud
merge: #969
ae14a21 
969: [Backport stable/8.2] Properly support Signal broadcasting r=nicpuppa a=remcowesterhoud

# Description
Backport of #966 to `stable/8.2`.

relates to #964

Co-authored-by: Remco Westerhoud <[email protected]>
@remcowesterhoud
fix: use different method
ff967e9 
variable was introduced in 8.3. We must use variables here.
@ghost
Copy link

ghost commented Nov 9, 2023

Canceled.

@nicpuppa
Copy link
Contributor

nicpuppa commented Nov 9, 2023

I was too fast 😆

@remcowesterhoud
Copy link
Contributor Author

🚤

bors merge

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

Test Results

  47 files  ±0    47 suites  ±0   1m 58s ⏱️ -1s
103 tests +2  103 ✔️ +2  0 💤 ±0  0 ❌ ±0 
332 runs  +6  332 ✔️ +6  0 💤 ±0  0 ❌ ±0 

Results for commit ff967e9. ± Comparison against base commit 9f9f92d.

@ghost
Copy link

ghost commented Nov 9, 2023

Build succeeded:

@ghost ghost merged commit d9ffbd9 into stable/8.2 Nov 9, 2023
11 checks passed
@ghost ghost deleted the backport-966-to-stable8.2 branch November 9, 2023 15:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicpuppa nicpuppa nicpuppa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remcowesterhoud @nicpuppa