Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#771 assert for error thrown #790

Closed
wants to merge 1 commit into from
Closed

Conversation

muraliweb9
Copy link

And an assert for exception thrown in Zeebe Process Test

I have added a new assert to ProcessInstanceAssert

Related issues

Issue #771 will be closed

closes #771

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • [ X] The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • [ X] The behavior is tested manually

Documentation:

  • [ X] Javadoc has been written
  • The documentation is updated

@remcowesterhoud
Copy link
Contributor

@muraliweb9 I'm questioning if this fits in the ProcessInstanceAssert. The way I see it it fits better in the JobAssert. I'd expect a test to start a process. At some point it reaches a service task and will throw an error. ZPT can be used to verify this error is then thrown. WDYT?

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Test Results

  47 files  ±0    47 suites  ±0   2m 25s ⏱️ -4s
100 tests ±0  100 ✔️ ±0  0 💤 ±0  0 ±0 
323 runs  ±0  323 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 43529e9. ± Comparison against base commit 89ceb43.

@remcowesterhoud
Copy link
Contributor

Hi @muraliweb9! I am closing this PR due to inactivity. Please reopen it if you're still interested in finishing the contribution 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZeebeTestThreadSupport.hasProcessInstanceThrownError assert
2 participants