Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sending signals #964

Closed
r-herd opened this issue Nov 9, 2023 · 8 comments · Fixed by #966
Closed

Support sending signals #964

r-herd opened this issue Nov 9, 2023 · 8 comments · Fixed by #966
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. severity/high Marks a bug as having a noticeable impact on the user with no known workaround

Comments

@r-herd
Copy link

r-herd commented Nov 9, 2023

Description

Signal events are introduced in camunda 8.3.0. When using the zeebe client to create a new signal event in a @ZeebeProcessTest the following error occurs:

io.camunda.zeebe.client.api.command.ClientStatusException
 at io.camunda.zeebe.client.impl.ZeebeClientFutureImpl.transformExecutionException([ZeebeClientFutureImpl.java:116](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-sandbox/workbench/workbench.html))
 at io.camunda.zeebe.client.impl.ZeebeClientFutureImpl.join([ZeebeClientFutureImpl.java:54](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-sandbox/workbench/workbench.html))
...
Caused by: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNKNOWN
 at java.base/java.util.concurrent.CompletableFuture.reportGet([CompletableFuture.java:396](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-sandbox/workbench/workbench.html))
 at java.base/java.util.concurrent.CompletableFuture.get([CompletableFuture.java:2073](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-sandbox/workbench/workbench.html))
 at io.camunda.zeebe.client.impl.ZeebeClientFutureImpl.join([ZeebeClientFutureImpl.java:52](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-sandbox/workbench/workbench.html))
 ... 72 more
Caused by: io.grpc.StatusRuntimeException: UNKNOWN
 at io.grpc.Status.asRuntimeException([Status.java:537](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-sandbox/workbench/workbench.html))
 at io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose([ClientCalls.java:481](vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-sandbox/workbench/workbench.html))
...

This issue is for signal events to be supported in zeebe-process-test

@r-herd r-herd added the kind/feature Categorizes an issue or PR as a feature, i.e. new behavior label Nov 9, 2023
@korthout
Copy link
Member

korthout commented Nov 9, 2023

Hi @r-herd 👋 Thanks for raising this!

Could you please provide a reproducible example? That would help us troubleshoot this.

@r-herd
Copy link
Author

r-herd commented Nov 9, 2023

This error occurs when executing the following code:
zeebeClient.newBroadcastSignalCommand().signalName("test").send().join();

@korthout
Copy link
Member

korthout commented Nov 9, 2023

Thanks @r-herd 👍

I've given it a try, and I see what's happening. I misread your feature request as a bug. I expected that broadcasting signals was actually already possible, just not supported by zeebe-process-test with assertions. However, it's clear now that actually broadcasting a signal in a zeebe-process-test test case is not supported.

I'll raise this with the team.

@korthout korthout added kind/bug Categorizes issue or PR as related to a bug. severity/high Marks a bug as having a noticeable impact on the user with no known workaround and removed kind/feature Categorizes an issue or PR as a feature, i.e. new behavior labels Nov 9, 2023
@korthout
Copy link
Member

korthout commented Nov 9, 2023

Personal triage:

  • issue is a bug, there is no workaround
  • priority upcoming, signals are supported since 8.3, and it should be possible to use them in ZPT as well
  • this usage does not include signal assertions
  • problem might be easily resolved by adding a GrpcResponseMapping entry for broadcast signal + don't assume that variables exist on the broadcast signal request
  • we should add some test cases for signal broadcasting to ZPT

@lzgabel Would this be something you could look into? Otherwise, I'll plan something with the team.

@remcowesterhoud remcowesterhoud self-assigned this Nov 9, 2023
@remcowesterhoud
Copy link
Contributor

I'll pick it up. I'm bored anyways 😄

@r-herd
Copy link
Author

r-herd commented Nov 9, 2023

Is there any plan to add assertions for signals soon?

@ghost ghost closed this as completed in 45b6ed5 Nov 9, 2023
ghost pushed a commit that referenced this issue Nov 9, 2023
967: [Backport stable/8.3] Properly support Signal broadcasting r=github-actions[bot] a=backport-action

# Description
Backport of #966 to `stable/8.3`.

relates to #964

Co-authored-by: Remco Westerhoud <[email protected]>
ghost pushed a commit that referenced this issue Nov 9, 2023
969: [Backport stable/8.2] Properly support Signal broadcasting r=nicpuppa a=remcowesterhoud

# Description
Backport of #966 to `stable/8.2`.

relates to #964

Co-authored-by: Remco Westerhoud <[email protected]>
ghost pushed a commit that referenced this issue Nov 9, 2023
969: [Backport stable/8.2] Properly support Signal broadcasting r=remcowesterhoud a=remcowesterhoud

# Description
Backport of #966 to `stable/8.2`.

relates to #964

Co-authored-by: Remco Westerhoud <[email protected]>
@remcowesterhoud
Copy link
Contributor

Is there any plan to add assertions for signals soon?

We haven't planned to add it at this time. I did create an issue for it just now (#971) because I would love to see these assertions as well.

@lzgabel I know you contributed Signals to Zeebe which is awesome. I just wanted to raise awareness for this feature request just in case you'd be interested in contributing it here as well. If you're not that's okay, then we'll pick it up within the team at some point 🙂

@lzgabel
Copy link

lzgabel commented Nov 9, 2023

💯 @remcowesterhoud Please assign the task to me.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. severity/high Marks a bug as having a noticeable impact on the user with no known workaround
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants