Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add granular logging to the logger #16734

Merged
merged 13 commits into from
Sep 20, 2024
Merged

chore: add granular logging to the logger #16734

merged 13 commits into from
Sep 20, 2024

Conversation

alishaz-polymath
Copy link
Member

@alishaz-polymath alishaz-polymath commented Sep 20, 2024 •
edited
Loading

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue here
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Sep 20, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 4:38am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 4:38am

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Sep 20, 2024
@alishaz-polymath alishaz-polymath marked this pull request as ready for review September 20, 2024 04:27
@dosubot dosubot bot added the docs area: docs, documentation, cal.com/docs label Sep 20, 2024
emrysal
emrysal approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK That's looking good to me, also nice we also deprecate NEXT_PUBLIC_DEBUG. Very happy with this.

@emrysal emrysal enabled auto-merge (squash) September 20, 2024 08:35
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 20, 2024

Graphite Automations

"Add ready-for-e2e label" took an action on this PR • (09/20/24)

1 label was added to this PR based on Keith Williams's automation.

@WNetin
Copy link

WNetin commented Sep 20, 2024 •
edited
Loading

OK That's looking good to me, also nice we also deprecate NEXT_PUBLIC_DEBUG. Very happy with this.

need to update the main README to remove the development tip about NEXT_PUBLIC_DEBUG

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

E2E results are ready!

@emrysal emrysal merged commit c4a1382 into main Sep 20, 2024
59 of 60 checks passed
@emrysal emrysal deleted the chore/add-granular-logging branch September 20, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal approved these changes

Assignees
No one assigned
Labels
core area: core, team members only docs area: docs, documentation, cal.com/docs enterprise area: enterprise, audit log, organisation, SAML, SSO ❗️ .env changes contains changes to env variables ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alishaz-polymath @WNetin @emrysal @keithwillcode