Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim down Config and Manager classes to remove unused behavior #689

Merged
merged 9 commits into from
Feb 13, 2024

Conversation

markstory
Copy link
Member

@markstory markstory commented Feb 12, 2024

Remove many methods from Config and Manager as migrations will only need to operate on a single connection at a time. We no longer need multiple environments or several other features like aliases. This allows for several parameters to be removed and tests to be simpler.

Part of #647

Also remove factory methods that we won't be using as configuration
is generated from cli options like source/plugin/connection now.
this extension isn't used any more.
Remove more functionality that we won't be using in migrations.
Without multiple environments, manager gets a bit simpler too.
We won't need these as each Config and Manager instance is attached
to a single connection.
@markstory markstory merged commit aa1399c into no-phinx Feb 13, 2024
11 checks passed
@markstory markstory deleted the trim-config branch February 13, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant