CW-782: Show error report popup without cooldown #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- put _lastOpenedWallet to avoid issues on windows (file is currently open by) - don't throw corruptedWalletsSeed - instead store it inside of secureStorage - await ExceptionHandler.onError calls where possible to makse sure that popup won't be canceled by some UI element - adjust BaseAlertDialog to be scrollable if the text is too long - add ExceptionHandler.resetLastPopupDate - that can be called when we want to show error report screen (bypassing cooldown)
MrCyjaneK
force-pushed
the
CW-782-show-error-report-popup-without-cooldown
branch
from
e40177e
to
212e59b
Compare
MrCyjaneK
force-pushed
the
CW-782-show-error-report-popup-without-cooldown
branch
from
8fa3993
to
d7327ce
Compare
OmarHatem28
requested changes
Oct 17, 2024
| } | ||
| } | ||
|
|
||
| // if all user's wallets are corrupted throw exception | ||
| throw error.toString() + "\n\n" + corruptedWalletsSeeds; | ||
| secureStorageShared.write(key: "corruptedWalletsSeed", value: corruptedWalletsSeeds); |
There was a problem hiding this comment.
why do you write them to secure storage? it will propagate already,
so like this you will add it twice, once from the error string and once more from the secure storage
There was a problem hiding this comment.
Otherwise the error report may contain the seed - which wouldn't be ideal
lib/src/screens/dashboard/desktop_widgets/desktop_wallet_selection_dropdown.dart
Outdated
Show resolved
Hide resolved
| final shouldCopy = await showPopUp<bool?>( | ||
| context: navigatorKey.currentContext!, | ||
| builder: (context) { | ||
| return AlertWithTwoActions( | ||
| isDividerExist: true, | ||
| alertTitle: S.of(context).error, | ||
| alertContent: content, | ||
| alertContent: content+"\n"+(seeds??""), |
There was a problem hiding this comment.
here I believe it would be duplicated, as the content is the error message, which contains the seeds as well
Comment on lines
+459
to
+462
| await ExceptionHandler.resetLastPopupDate(); | ||
| final err = e.toString() + ((await secureStorageShared.read(key: "corruptedWalletsSeed"))??"unable to retrieve seeds"); | ||
| await secureStorageShared.delete(key: "corruptedWalletsSeed"); | ||
| await ExceptionHandler.onError(FlutterErrorDetails(exception: err)); |
lib/di.dart
Outdated
There was a problem hiding this comment.
haven't reviewed this file yet, but double check it as well please
Co-authored-by: Omar Hatem <[email protected]>
MrCyjaneK
force-pushed
the
CW-782-show-error-report-popup-without-cooldown
branch
from
5b72be3
to
159f433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
improve exception throwing on broken wallets
Pull Request - Checklist