Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(yeti): YETI 2024 updates #4100

Merged
merged 16 commits into from
Oct 18, 2024
Merged

feat(yeti): YETI 2024 updates #4100

merged 16 commits into from
Oct 18, 2024

Conversation

iamvdo
Copy link
Contributor

@iamvdo iamvdo commented Oct 16, 2024

Hello,
Here are changes to the YETI app:

  • New FFVL (Fédération Française de Vol Libre) layer
  • New style and categories for data-avalanche layer (<15days, <180days, all)
  • New style for routes and edit mode (show editable points)
  • Ability to select one or more winter routes, and convert them into outing (to edit/export)
  • IGN Scan25 layer shows starting zoom 13.5, instead of 15
  • Preserve map position

PS: There is a bug right now with ol and WMS layer, but merging #4093 will fix it

Thanks for review!
Vincent

New FFVL layer
image

New data-avalanche style and control
image

Selected winter route
image

New route style and edit mode
image

@iamvdo
refactor(yeti): Better event management for each layers
4d80c92 
- events occur on map
- overlaysLayers send event only on "good" layer (visible on top), no matter its type (vector, image, etc.)
- each layer can react to event, and also, when layer "loose" event
@iamvdo
build(yeti): Lint
991fea7
@iamvdo
feat(yeti): Add FFVL layer
87a4f48
@iamvdo
feat(yeti): Split large and small layers in 2 groups
6f09fac
@iamvdo
feat(yeti): Add layer's content ability to control layer
f6fc1fe
@iamvdo
feat(yeti): Data-Avalanche control and new style
7de6832
@iamvdo
feat(yeti): Add pencil icon in edit mode
513a52c
@iamvdo
feat(yeti): New styles for route features and edit mode
3d9a954
@iamvdo
refactor(yeti): Tabs
8b8391e
@iamvdo
feat(yeti): Rename tab 'Outing' to 'My Outing'
555017a
@iamvdo
feat(yeti): Convert winter route to an editable outing
1783314 
- New control for winter routes
- Selectable one or many winter routes
- Convert to an outing
@iamvdo
feat(yeti): Preserve map position
7ea01f2
@iamvdo
fix(yeti): C2C routes sometimes don't have geom_detail
c9d64d7
@iamvdo
feat(yeti): Use fixed zoom delta
abb1052
@iamvdo
feat(yeti): IGN layer: show scan25 tiles at lower zoom
a8891c9
@iamvdo
fix(yeti): @turf/intersect need one FeatureCollection
825f06b
@iamvdo iamvdo changed the title YETI 2024 updates feat(yeti): YETI 2024 updates Oct 16, 2024
@github-actions github-actions bot added the enhancement New feature or request label Oct 16, 2024
@brunobesson
Copy link
Member

As always, thanks for the huge work and all the improvements. I have seen a single glitch, due to the evolutions of the advertisement handling on c2c (I must confess I didn't follow what was done @flob38). $yeti-height must be defined as calc(100vh - #{$navbarad-height}) instead of calc(100vh - #{$navbar-height}).

brunobesson
brunobesson approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@brunobesson brunobesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry no time right now for a code review, I did only functional tests, but I know from experienc there isn't much to say to your PRs 👏)

@brunobesson brunobesson merged commit 3761450 into c2corg:master Oct 18, 2024
7 of 8 checks passed
@brunobesson
Copy link
Member

I merged and fixed the issue anyway.

A comment I forgot:
image

Is it really usefull, couldn't it be skipped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobesson brunobesson brunobesson approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamvdo @brunobesson