Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Zimg for FFmpeg #1427

Closed
wants to merge 5 commits into from
Closed

Conversation

callisto-jovy
Copy link

@callisto-jovy callisto-jovy commented Oct 19, 2023

This should close https://github.com/bytedeco/javacv/issues/1389 and allow for tonemapping with FFmpeg.

Include the flag --enable-libzimg for FFmpeg, to enable libzimg
@callisto-jovy callisto-jovy marked this pull request as draft October 20, 2023 15:21
Fix ZLib version (see https://www.zlib.net), only 1.3 is available right now.
Add the required Zimg download, extraction and compilation process for FFmpeg to compile with the desired flag. Some parts are not included yet.
Fixes the configure file not being found. I missed out on that, as - apparently - I must have executed the autogen.sh by mistake
@callisto-jovy
Copy link
Author

As the non-x86_64 builds are failing with the same error message, they must be missing a certain flag. Do you have an idea on what that could be? @saudet

@saudet
Copy link
Member

saudet commented Oct 22, 2023

2023-10-21T11:03:27.4134446Z require_pkg_config libzimg zimg >= 2.7.0 zimg.h zimg_get_api_version
2023-10-21T11:03:27.4134763Z check_pkg_config libzimg zimg >= 2.7.0 zimg.h zimg_get_api_version
2023-10-21T11:03:27.4135071Z test_pkg_config libzimg zimg >= 2.7.0 zimg.h zimg_get_api_version
2023-10-21T11:03:27.4135335Z false --exists --print-errors zimg >= 2.7.0
2023-10-21T11:03:27.4135609Z ERROR: zimg >= 2.7.0 not found using pkg-config

pkg-config doesn't work for cross compilation

@b005t3r
Copy link

b005t3r commented Dec 18, 2023

I see that @callisto-jovy nearly figured it out, but I can't see from your comments what was the issue with the change they made.

@saudet
Copy link
Member

saudet commented Dec 18, 2023

We can't use pkg-config, unless you figure out a way to make it work well for cross compilation, Android, Windows, etc. It's usually easier to patch FFmpeg's configure to prevent it from using pkg-config

@saudet
Copy link
Member

saudet commented Apr 7, 2024

Superseded by pull #1481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants