Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Arrow using LLVM preset #1039

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

junlarsen
Copy link
Member

This is a follow up to #1029

Builds the Apache Arrow preset using the LLVM preset instead of compiling LLVM on its own.

This does not work in its current state (as discussed on Gitter)

@saudet
Copy link
Member

saudet commented May 3, 2021

It appears that the CMake config files from LLVM that Arrow uses needs all the static libraries, so to do things correctly we would need to bundle all of them in the JAR files for all platforms. Right now, we're bundling them only for Windows because it doesn't support dynamic libraries for LLVM, and that's why the JAR files for that platform are so huge. We could hack the CMake build files to remove all traces of the static libraries, but Arrow itself was designed to link statically with LLVM anyways, so it may be more trouble than it's worth trying to figure out a way to make it all work with the dynamic libraries...

@junlarsen
Copy link
Member Author

I see, I think we should do what we did for the LLVM build here as well then right?

@saudet
Copy link
Member

saudet commented May 7, 2021

We could, but it doesn't build as much of LLVM and it looks like we won't need it:
https://github.com/bytedeco/javacpp-presets/actions/runs/820400693

@junlarsen
Copy link
Member Author

Okay, I suppose I can close this then?

@saudet
Copy link
Member

saudet commented May 8, 2021

I suppose, but we can keep it open as a reminder that it would be nice to do something. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants