Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ToString method for Mutability struct #220

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

martindevans
Copy link
Contributor

Added ToString method for Mutability struct

@martindevans
Copy link
Contributor Author

It looks like the CI test runner crashed, I'm not sure why. Tests pass locally.

@peterhuene
Copy link
Member

peterhuene commented Feb 6, 2023

I suspect we need to sync to bytecodealliance/wasmtime#5683. The reason it's probably not crashing for you locally is you're using a slightly older Wasmtime library from a previous build. Cleaning your repo to redownload the latest dev build would likely show it (which is how the CI operates).

Unrelated to the crash, CI's been flaky on Windows for an unknown reason (occasionally fails to download the wasmtime tarballs from GitHub).

I'll see about getting CI fixed shortly.

@peterhuene
Copy link
Member

I put up #221 to fix CI; we can merge that and then rebase this PR on top.

@peterhuene
Copy link
Member

peterhuene commented Feb 6, 2023

If we rebase this, I'll merge with a (mostly) green CI.

This and the other PR (#219) will go into the 7.0.0 release, unfortunately, unless you really need me to backport either to the 6.0 release which is imminent.

@martindevans
Copy link
Contributor Author

Rebased onto main.

go into the 7.0.0 release

That's fine, neither are critical on my end :)

@peterhuene peterhuene merged commit c0117d1 into bytecodealliance:main Feb 7, 2023
@martindevans martindevans deleted the Mutability_ToString branch February 7, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants