Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mmap flags for AOT loader on non-Linux SGX platforms #3890

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix mmap flags for AOT loader on non-Linux SGX platforms #3890

merged 1 commit into from
Oct 30, 2024

Conversation

lum1n0us
Copy link
Collaborator

fix #3883

@TianlongLiang
Copy link
Contributor

LGTM

xujuntwt95329
xujuntwt95329 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lum1n0us lum1n0us merged commit 1138435 into bytecodealliance:main Oct 30, 2024
383 checks passed
@lum1n0us lum1n0us deleted the fix/32bit_mmap_assertion branch October 30, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh approved these changes

@xujuntwt95329 xujuntwt95329 xujuntwt95329 approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed assertion in aot_loader in spec test on SGX w/ threads
4 participants
@lum1n0us @TianlongLiang @xujuntwt95329 @wenyongh