New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overflow in ParseBase58/ParseBase32 #45

Closed

dnephin wants to merge 1 commit into bwmarrin:master from dnephin:error-on-overflow

dnephin commented Apr 26, 2022 •

edited

Loading

Fixes #42

The ID should not be allowed to overflow an int64. The test cases added here fail before the code change.

dnephin force-pushed the error-on-overflow branch from 8274dc1 to 3186fca Compare

April 26, 2022 21:05


          fix: overflow

8e8d444

The ID should not be allowed to overflow an int64

dnephin force-pushed the error-on-overflow branch from 3186fca to 8e8d444 Compare

April 26, 2022 21:05

dnephin mentioned this pull request

Update snowflake dependency and add more tests infrahq/infra#1738

Merged

Author

dnephin commented May 3, 2022

After doing some more testing with fuzz tests I see this is not at all the right way of dealing with overflow.

dnephin closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet