Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for the Joyroid Loob #545

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

blackspherefollower
Copy link
Collaborator

@blackspherefollower blackspherefollower commented Jan 4, 2023

This change will require a fix in btleplug, as the LOOB has duplicate characteristic UUIDs and btleplug gives us the last one, not the first. See deviceplug/btleplug#365 for my attempt at a fix; my concern is that there's probably a better way to collate without duplicates than using fold.

qdot and others added 7 commits October 1, 2024 19:24
…er as empty

If we get back a Vec<Option<Hardwarecommand>> that isn't empty but is
nothing but None, treat it as empty. Otherwise we'll spam devices with
very weird output.
Interestingly, this rabbit device actually supports oscillation range!
is chonk. so chonk. 100ms timing sucks. But it works. Sorta.
This change will require a fix in btleplug, as the LOOB has duplicate
characteristic UUIDs and btleplug gives us the last one, not the first.
See deviceplug/btleplug@4a2089b for my attempt at a fix (only tested on
Windows, but passing tests on all); my concern is that there's probably
a better way to collet without duplicates than using fold.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants