Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/api-error-handling #53

Open
wants to merge 314 commits into
base: feat/api-error-handling
Choose a base branch
from
Open

feat/api-error-handling #53

wants to merge 314 commits into from

Conversation

shon-button
Copy link
Collaborator

Addresses API Error handling

📛 Add Generic Error Handling in api\main.py

  1. Added function handle_error:

    • This function manages exceptions gracefully.
  2. Updated Functions Using try...except Blocks:

    • Errors encountered in all Main.py functions now handled by handle_error.

🚀 Impact:

  • All external API calls include more robust error handling.
  • Functions executed during application startup include more robust error handling.
  • API routes accessed by the frontend include more robust error handling.

Copy link

@joshgamache joshgamache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not well versed in Python's exception handling, but the try/except pattern is clear. The handle_error function is simple and clean, and going through the rest of the code the functions needing that error handling are all covered.

Looks good to me! 🌮

monicakochofar and others added 30 commits October 4, 2023 15:30
merge-develop-into-main-oct-05
Filtering now removes bins that don't have relevant field
merge-develop-into-main-Oct 6
Updating Opacity and Animating collapse
186055022 & 186034612 common sensor refactor & modulizations
merge-develop-into-main-Oct10
…are-docker-cleanup

Modified deploy sh to incorpoare docker cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants