-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/api-error-handling #53
Open
shon-button
wants to merge
314
commits into
feat/api-error-handling
Choose a base branch
from
develop
base: feat/api-error-handling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgamache
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not well versed in Python's exception handling, but the try
/except
pattern is clear. The handle_error
function is simple and clean, and going through the rest of the code the functions needing that error handling are all covered.
Looks good to me! 🌮
Route is Now Created From Filters and Defined Start/End points
adding mobile support
…ragged to get updated time/distance
…ototype into email-notify
…ototype into 186123335-google-sheet-clean-up
186123335 google sheet clean up
Mk filtered
merge-develop-into-main-oct-05
Filtering now removes bins that don't have relevant field
merge-develop-into-main-Oct 6
…ototype into 186055022-common-sensor-refactor
Updating Opacity and Animating collapse
186055022 & 186034612 common sensor refactor & modulizations
merge-develop-into-main-Oct10
…are-docker-cleanup Modified deploy sh to incorpoare docker cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses API Error handling
📛 Add Generic Error Handling in api\main.py
Added function
handle_error
:Updated Functions Using
try...except
Blocks:handle_error
.🚀 Impact: