This TODO has already been resolved #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sporkmonger
added
size/x-small
malizz
approved these changes
Jul 25, 2023
|
I refuse to believe that tests failed because a comment was deleted. |
|
Ah, tests are failing because the adapter was updated with the new |
sporkmonger
added a commit
that referenced
this pull request
May 17, 2024
….555b57ec2 555b57ec2 rules_go//proto : use go_grpc_v2 instead of go_grpc (#94) 7e7c9eab8 Bump io_bazel_rules_go -> 0.46.0 (#93) 0c46c0101 cel: Add canonical CEL (dev.cel.expr) fields (#89) 033564927 pgv_plugin_go : Use protoc_gen_validate instead of xds (#92) 6b7cb9e61 Migrate from github.com/golang/protobuf to google.golang.org/protobuf (#90) 8a4994d93 Bump github.com/envoyproxy/protoc-gen-validate from 1.0.2 to 1.0.4 (#88) ee0267137 Add extension point to StringMatcher (#87) 91a88dc4e Synchronize dependencies versions between go.mod and bazel (#85) 0fa0005c9 annotations: correct go_package (#80) 8e57aacd0 ci: Add `go build` CI job (#78) 5b9bca554 Revert "Add canonical CEL support: dev.cel.expr (#75)" (#79) 0f5e0d9db Add canonical CEL support: dev.cel.expr (#75) 3a472e524 bazel: Migrate py_proto_library to `@com_github_grpc_grpc` (#74) 523115ebc bazel: fix "missing strict dependencies" build issue (#72) 8bd2eac9f Bump bazel to 4.2.2 (#68) 776c4db84 cel: add a description to the AST (#61) e9ce68804 Add application_utilization (#62) 4003588d1 Allow cpu_utilizatoin larger than 1.0. (#60) 32f1caf87 Add eps and named metrics. (#58) 46e39c7b9 Update GoogleAPIs to 114a745 (2023-01-10) (#55) 06c439db2 orca: replace uint64 rps with double rps_fractional (#54) c261a164b cleanup: Remove unused imports (#43) 1e77728a1 CEL Matchers: remove extension tag until implemented (#36) d35b9e6a8 matchers: add CEL matcher, input (#31) 42e9329d8 Bump googleapis dependency to 2019-12-02 (#34) 70da609f7 xRFC TP2: Dynamically Generated Cacheable xDS Resources (#10) eded34331 matcher: add server name matcher (#24) 7f1daf172 docs: fixes to create valid RST (#32) 4a2b9fdd4 matchers: add range matchers (#26) 0fa49ea1d removing unused imports (#25) git-subtree-dir: crates/ext-processor/protobuf/xds git-subtree-split: 555b57ec207be86f811fb0c04752db6f85e3d7e2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR that resolved this never removed the TODO comment.